From: Alex Elder <elder@riscstar.com>
To: Troy Mitchell <troymitchell988@gmail.com>,
Alex Elder <elder@ieee.org>, Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>
Cc: linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH v7 2/2] i2c: spacemit: add support for SpacemiT K1 SoC
Date: Tue, 18 Mar 2025 07:04:19 -0500 [thread overview]
Message-ID: <a7862a8b-4d81-4b1b-90d9-3cedde0699a5@riscstar.com> (raw)
In-Reply-To: <c7dc26a0-7cbc-4909-b2ac-582d108fc5e7@gmail.com>
On 3/18/25 12:44 AM, Troy Mitchell wrote:
>> I'll leave it up to the maintainer to decide whether these
>> comments can just be ignored--my Reviewed-by is fine, even
>> if you don't change these.
>>
>> -Alex
> I know it's right what you said.
> But I don't know if it's worth to send v8?
> Maybe I can fix it when I add FIFO function?
> If I'm wrong, let me know.
Unless the maintainer wants you do do v8, please just
address these suggestions later. Thank you.
-Alex
next prev parent reply other threads:[~2025-03-18 12:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 7:43 [PATCH v7 0/2] riscv: spacemit: add i2c support to K1 SoC Troy Mitchell
2025-03-16 7:43 ` [PATCH v7 1/2] dt-bindings: i2c: spacemit: add support for " Troy Mitchell
2025-03-16 7:43 ` [PATCH v7 2/2] i2c: spacemit: add support for SpacemiT " Troy Mitchell
2025-03-17 21:42 ` Alex Elder
2025-03-18 5:44 ` Troy Mitchell
2025-03-18 12:04 ` Alex Elder [this message]
2025-03-18 21:41 ` Andi Shyti
2025-03-18 21:55 ` Alex Elder
2025-03-18 22:18 ` Andi Shyti
2025-03-19 6:57 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7862a8b-4d81-4b1b-90d9-3cedde0699a5@riscstar.com \
--to=elder@riscstar.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@ieee.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troymitchell988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox