From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D9815B128 for ; Fri, 31 May 2024 13:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717163680; cv=none; b=E9aUoc0uK6incDX5WrVqrpGslDOsOxxprLpxKmws8sozDF10lOLOkVO6kspYErG1q8AQJC41WWzDhX8qKNBsxWW/4V45hcBcJCdtIN9+FeAXR5z3m41Yu2sc4nVMQgemUMbeXXVn8IwDEd+Fd+Kv9JfIiVlFx3HhHyl8R3H2Ozw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717163680; c=relaxed/simple; bh=XR/ddc62BPork8DuyEUzWe7Wo5ppryZ51hCLzsBTeZw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s+PPD6RVMmUXrjFJdN49GWLla8/dDBCOazkjL9lUJ4geNG6YXQD7T+Q+/CpMGR70JhQvZi8/gyaNllgC/5mA8oK9ZhHmvYAPGZEZm53xesvY4AiroGHOF/C3eOXc7VRO8tjzJAPAOva5cCPzs8/Yu6XnjYcDi6I3j8TPY07txNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QbK9s/zi; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QbK9s/zi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717163678; x=1748699678; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=XR/ddc62BPork8DuyEUzWe7Wo5ppryZ51hCLzsBTeZw=; b=QbK9s/ziZFnb5qrz2bE99Apj8SIYs48v+xzzkF3eKx4piR69ZXTiVLnV IVoGO/u5duymcXldrCAD2hzxBi94CKSHZRnG27+ma0jU6t5NYQ5LISunu +9oEMPCdAT8Q88rlULP2Dn+xdl0u3z20tjTinfU6/tjZNJ928JVIgxJvJ f9HvUdB3j9YWycfBw0hx5Qx9ziSBuNIpXAk65f7a/dVrRFj06dxVVpc92 mWocLcgl4khvTpvhiQ/BiXK5pfGjCEW3rWCRCPnxo4N68la6WOmKkovH/ w4JBjRiPCwo/nFp1yM4EcbNGvQsf4JD6IykkPPMXprGcVmF7t9frCCtPf A==; X-CSE-ConnectionGUID: l1yGNl7kShaWPnTOVqjgtw== X-CSE-MsgGUID: DMCZ7kFDR0m2DIf6JOvZ9Q== X-IronPort-AV: E=McAfee;i="6600,9927,11088"; a="17552318" X-IronPort-AV: E=Sophos;i="6.08,204,1712646000"; d="scan'208";a="17552318" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2024 06:54:38 -0700 X-CSE-ConnectionGUID: iIz30gftRoaQDqqlalwDTw== X-CSE-MsgGUID: J/aN8dCHSEGccmvWyQq1yw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,204,1712646000"; d="scan'208";a="36157633" Received: from ehlflashnuc2.fi.intel.com (HELO [10.237.72.57]) ([10.237.72.57]) by fmviesa008.fm.intel.com with ESMTP; 31 May 2024 06:54:37 -0700 Message-ID: Date: Fri, 31 May 2024 16:54:35 +0300 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: designware: Fix the functionality flags of the slave-only interface To: Jean Delvare , Andy Shevchenko Cc: Linux I2C , Mika Westerberg , Jan Dabros , Andi Shyti References: <20240531111748.441a85b6@endymion.delvare> <20240531113113.47225d65@endymion.delvare> Content-Language: en-US From: Jarkko Nikula In-Reply-To: <20240531113113.47225d65@endymion.delvare> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/31/24 12:31 PM, Jean Delvare wrote: > On Fri, 31 May 2024 12:23:26 +0300, Andy Shevchenko wrote: >> On Fri, May 31, 2024 at 11:17:48AM +0200, Jean Delvare wrote: >>> When an I2C adapter acts only as a slave, it should not claim to >>> support I2C master capabilities. >>> >>> Fixes: 5b6d721b266a ("i2c: designware: enable SLAVE in platform module") >>> Signed-off-by: Jean Delvare >> >> The below can be separated by >> >> --- >> >> to avoid noise in the commit messages. The effect, namely Cc'ing to people, >> will stay the same. > > Noted, I'll do that from now on. > >>> Cc: Luis Oliveira > > BTW, the address above is no longer valid so it should be omitted when replying. > >>> Cc: Jarkko Nikula >>> Cc: Andy Shevchenko >>> Cc: Mika Westerberg >>> Cc: Jan Dabros >>> Cc: Andi Shyti >>> --- >> >> Other than that, LGTM, >> Reviewed-by: Andy Shevchenko > Acked-by: Jarkko Nikula Tested-by: Jarkko Nikula