Re: [PATCH v5 7/9] i2c: atr: add flags parameter to i2c_atr_new()

Wolfram Sang
2025-05-22T08:50:26Z

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

On Wed, May 07, 2025 at 03:19:13PM +0300, Cosmin Tanislav wrote:
> In preparation for adding multiple flags that change the behavior,
> add a flags parameter to i2c_atr_new() and an i2c_atr_flags enum.
>
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>

How did you guys get it to build?

CC drivers/i2c/i2c-atr.o
In file included from drivers/i2c/i2c-atr.c:12:
./include/linux/i2c-atr.h:25:1: error: empty enum is invalid
25 | };
| ^
make[4]: *** [scripts/Makefile.build:203: drivers/i2c/i2c-atr.o] Error 1

I'll squash patches 7+8 to avoid it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]