Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode

Wolfram Sang
2025-05-19T11:25:16Z

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

> > - info.of_node = of_node_get(node);
> > + info.fwnode = of_fwnode_handle(of_node_get(node));
>
> What puzzles me here is that of_node_get(). We already do the same in the I²C
> core, does it really need the second bump of the reference counting?

I'd think so. i2c_board_info has its own source file outside of the I2C
core because it is used before the I2C core is even initialized. That is
basically the reason for its existence.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]