Re: [PATCH 1/3] i2c: powermac: convert of_node usage to fwnode

Andy Shevchenko
2025-05-19T11:18:42Z

On Mon, May 19, 2025 at 01:13:12PM +0200, Wolfram Sang wrote:
> 'of_node' in i2c_boardinfo is deprecated in favor of 'fwnode'. The I2C
> core handles them equally, so simply convert this driver to fwnode.

...

> - info.of_node = of_node_get(node);
> + info.fwnode = of_fwnode_handle(of_node_get(node));

What puzzles me here is that of_node_get(). We already do the same in the I²C
core, does it really need the second bump of the reference counting?

In any case, this patch doesn't change the status quo, I'm fine to leave the
research for the later.

--
With Best Regards,
Andy Shevchenko