From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 1/3] i2ctransfer: Don't free memory which was never allocated
Date: Mon, 19 May 2025 17:31:52 +0200 [thread overview]
Message-ID: <aCtO6KrgOEeyA19C@shikoro> (raw)
In-Reply-To: <20250513172119.09548573@endymion>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Tue, May 13, 2025 at 05:21:19PM +0200, Jean Delvare wrote:
> If an error occurs while msgs[] is been prepared for the transfer,
> we jump to the clean-up path. How many buffers need to be freed
> depends on the state. If we were parsing data, we should free up to
> nmsgs. However, if we were parsing descriptors, we should free
> up to nmsgs - 1 only. The code was unconditionally freeing up to
> nmsgs, potentially freeing a non-allocated buffer.
>
> In most cases, it was not a problem, we would simply call free() on a
> NULL pointer and that's a no-op. However, if msgs[] was full then we
> would access memory beyond its end and call free() on a random
> pointer.
>
> Fixes: 9fc53a7fc669 ("i2c-tools: add new tool 'i2ctransfer'")
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
Applied, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-05-19 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 15:21 [PATCH 1/3] i2ctransfer: Don't free memory which was never allocated Jean Delvare
2025-05-13 15:23 ` [PATCH 2/3] i2ctransfer: Prevent msgs[] overflow with many parameters Jean Delvare
2025-05-19 15:35 ` Wolfram Sang
2025-05-13 15:35 ` [PATCH 3/3] i2ctransfer: Zero out memory passed to ioctl() Jean Delvare
2025-05-19 15:36 ` Wolfram Sang
2025-05-19 15:31 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCtO6KrgOEeyA19C@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox