From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
Cc: linux-i2c@vger.kernel.org, andi.shyti@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] i2c/designware: Fix an initialization issue
Date: Thu, 26 Jun 2025 22:33:26 +0300 [thread overview]
Message-ID: <aF2ghjEsRbr5-xJg@smile.fi.intel.com> (raw)
In-Reply-To: <20250626190525.469618-1-michael.j.ruhl@intel.com>
On Thu, Jun 26, 2025 at 03:05:25PM -0400, Michael J. Ruhl wrote:
> The i2c_dw_xfer_init() function requires msgs and msg_write_idx from the
> dev context to be initialized.
>
> amd_i2c_dw_xfer_quirk() inits msgs and msgs_num, but not msg_write_idx.
>
> This could allow an out of bounds access (of msgs).
>
> Initialize msg_write_idx before calling i2c_dw_xfer_init().
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-26 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 19:05 [PATCH] i2c/designware: Fix an initialization issue Michael J. Ruhl
2025-06-26 19:33 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-06-27 14:35 Michael J. Ruhl
2025-06-30 18:03 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF2ghjEsRbr5-xJg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox