* [PATCH] drivers: i2c: Geode ACCESS.bus depends on HAS_IOPORT
@ 2025-06-06 7:56 Johannes Berg
2025-06-27 10:31 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2025-06-06 7:56 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-i2c, Andi Shyti, Johannes Berg, Arnd Bergmann
From: Johannes Berg <johannes.berg@intel.com>
It already depends on X86_32, but that's also set for ARCH=um.
Recent changes made UML no longer have IO port access since
it's not needed, but this driver uses it. Build it only for
HAS_IOPORT. This is pretty much the same as depending on X86,
but on the off-chance that HAS_IOPORT will ever be optional
on x86 HAS_IOPORT is the real prerequisite.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/i2c/busses/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 48c5ab832009..0a4ecccd1851 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -1530,7 +1530,7 @@ config I2C_XGENE_SLIMPRO
config SCx200_ACB
tristate "Geode ACCESS.bus support"
- depends on X86_32 && PCI
+ depends on X86_32 && PCI && HAS_IOPORT
help
Enable the use of the ACCESS.bus controllers on the Geode SCx200 and
SC1100 processors and the CS5535 and CS5536 Geode companion devices.
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: i2c: Geode ACCESS.bus depends on HAS_IOPORT
2025-06-06 7:56 [PATCH] drivers: i2c: Geode ACCESS.bus depends on HAS_IOPORT Johannes Berg
@ 2025-06-27 10:31 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2025-06-27 10:31 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-kernel, linux-i2c, Andi Shyti, Johannes Berg, Arnd Bergmann
On Fri, Jun 06, 2025 at 09:56:52AM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> It already depends on X86_32, but that's also set for ARCH=um.
> Recent changes made UML no longer have IO port access since
> it's not needed, but this driver uses it. Build it only for
> HAS_IOPORT. This is pretty much the same as depending on X86,
> but on the off-chance that HAS_IOPORT will ever be optional
> on x86 HAS_IOPORT is the real prerequisite.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Applied to for-current, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-27 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-06 7:56 [PATCH] drivers: i2c: Geode ACCESS.bus depends on HAS_IOPORT Johannes Berg
2025-06-27 10:31 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).