From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Randolph Ha <rha051117@gmail.com>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Mika Westerberg <westeri@kernel.org>
Subject: Re: [PATCH v1 1/1] i2c: acpi: Replace custom code with device_match_acpi_handle()
Date: Tue, 24 Jun 2025 14:13:59 +0300 [thread overview]
Message-ID: <aFqId5DaRTWxUXrn@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0hB1dJ-wb1_Wn0yrf0JVfpqR9cZ7xBmjKM2kB1Q=FF=yQ@mail.gmail.com>
On Tue, Jun 24, 2025 at 12:18:22PM +0200, Rafael J. Wysocki wrote:
> On Tue, Jun 24, 2025 at 9:38 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Jun 24, 2025 at 10:25:59AM +0300, Mika Westerberg wrote:
> > > On Tue, Jun 24, 2025 at 10:19:02AM +0300, Andy Shevchenko wrote:
...
> > > But like I said, no objections. I just don't think this improves anything.
> >
> > I think there is an improvement.
>
> For example, this helps (I think) when someone uses something like LXR
> to look for places where a device is matched against a given ACPI
> handle, but only as long as device_match_acpi_handle() is used in all
> of those places consistently.
Yeah, this is a problem in the kernel that we may have a lot of legacy code
here and there. Unfortunately I have no plan to go all over, this is just
an ad-hoc change while debugging a regression (I hope not related to this
piece of code).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-24 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 13:45 [PATCH v1 1/1] i2c: acpi: Replace custom code with device_match_acpi_handle() Andy Shevchenko
2025-06-24 5:45 ` Mika Westerberg
2025-06-24 7:19 ` Andy Shevchenko
2025-06-24 7:25 ` Mika Westerberg
2025-06-24 7:35 ` Andy Shevchenko
2025-06-24 10:18 ` Rafael J. Wysocki
2025-06-24 11:13 ` Andy Shevchenko [this message]
2025-06-27 10:22 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFqId5DaRTWxUXrn@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rha051117@gmail.com \
--cc=westeri@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox