From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2167253331; Mon, 30 Jun 2025 10:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751277786; cv=none; b=McvSB/YoVzVDWRD04GLZzYRrt1/xxrsdEbBgxvlpm61uIhS62Nmyp8m05reDQsFGKBcQtPzsE0Uv7+9h6AWf4NfUvEV5yrkt7Go63WOc6oCzUnXCi6od4NsT6RLRkrrVmAyqZqccoj+3P/Kq4zuiVOAWPEPFgjYYaTzLehKx0fY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751277786; c=relaxed/simple; bh=wNvXIKtXvn6NfqG8kHUW3OxzPA4DPds/TwxFtq3HPoo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FfMhDR+7luH+55TuQTneme4cUEq6nZWU1bgbxqOhR3fDPtF/BG4dK5erErwudhXg9uXSVYvdoKsfKkGhHL1BmvLX9Iw/lsNDiyw5WQYcUeoNxIgVmurQ5m3nYE42zP4Sxm2sOeibx1t3buMyAUHqQj1dqP31GjMyliZWJJ39NiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=W6bmcTLT; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W6bmcTLT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751277785; x=1782813785; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wNvXIKtXvn6NfqG8kHUW3OxzPA4DPds/TwxFtq3HPoo=; b=W6bmcTLTVYPMvsDTN4SBLEhPR2ItTXK0O0XsSH+Bb9AfwlljAhG9juoe 60yHmhvLHtODpZDGrvyiEEctx+o9RobEEdpYF37j5dgBim2MAQJuaa/E7 IPANcpZXIxmRSYnu+jTLpzzdo9KdiMbFiWVIik6meLdS0O8VdB/jOoRqc kZQxKMIMHtTgZC9vq6eLUTBq9A/T7UhYUwetwUzWZ3oX7mFReOcEH9eQ1 M6AcvcY4WD9jYlXhDuU/Tj9wTDmX5atc5+ZVkBhpvIWjwH7TIpqmeCM0S oxFJVG8Ek9/S/4HjRCHlHgvOl3+C/DdJQV3nJJ+YWDUjtwHqfv95wshP2 Q==; X-CSE-ConnectionGUID: dwEMDsbSSUeAtKiW7tvqrA== X-CSE-MsgGUID: XtvOGhUUQHWcgpttyAvW3w== X-IronPort-AV: E=McAfee;i="6800,10657,11479"; a="53359673" X-IronPort-AV: E=Sophos;i="6.16,277,1744095600"; d="scan'208";a="53359673" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2025 03:03:04 -0700 X-CSE-ConnectionGUID: Mte4yZEWQ7ePO1tG76oQBw== X-CSE-MsgGUID: 0KLmOUJvRNOWydQS4DSd1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,277,1744095600"; d="scan'208";a="159145392" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2025 03:03:01 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uWBLl-0000000BGqE-0VOl; Mon, 30 Jun 2025 13:02:57 +0300 Date: Mon, 30 Jun 2025 13:02:56 +0300 From: Andy Shevchenko To: Heikki Krogerus Cc: Rodrigo Vivi , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Jarkko Nikula , David Airlie , Simona Vetter , Mika Westerberg , Jan Dabros , Andi Shyti , Raag Jadav , "Tauro, Riana" , "Adatrao, Srinivasa" , "Michael J. Ruhl" , intel-xe@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/4] i2c: designware: Add quirk for Intel Xe Message-ID: References: <20250627135314.873972-1-heikki.krogerus@linux.intel.com> <20250627135314.873972-2-heikki.krogerus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jun 30, 2025 at 11:10:00AM +0300, Heikki Krogerus wrote: > On Mon, Jun 30, 2025 at 10:30:19AM +0300, Andy Shevchenko wrote: > > On Fri, Jun 27, 2025 at 05:32:01PM -0400, Rodrigo Vivi wrote: > > > On Fri, Jun 27, 2025 at 05:13:36PM +0300, Andy Shevchenko wrote: > > > > On Fri, Jun 27, 2025 at 04:53:11PM +0300, Heikki Krogerus wrote: ... > > > > > static int dw_i2c_plat_probe(struct platform_device *pdev) > > > > > { > > > > > + u32 flags = (uintptr_t)device_get_match_data(&pdev->dev); > > > > > > > > > - dev->flags = (uintptr_t)device_get_match_data(device); > > > > > if (device_property_present(device, "wx,i2c-snps-model")) > > > > > - dev->flags = MODEL_WANGXUN_SP | ACCESS_POLLING; > > > > > + flags = MODEL_WANGXUN_SP | ACCESS_POLLING; > > > > > > > > > > dev->dev = device; > > > > > dev->irq = irq; > > > > > + dev->flags = flags; > > > > > > > > Maybe I'm missing something, but why do we need these (above) changes? > > > > > > in between, it is introduced a new one: > > > flags |= ACCESS_POLLING; > > > > > > So, the initialization moved up, before the ACCESS_POLLING, and > > > it let the assignment to the last, along with the group. > > > > I still don't get. The cited code is complete equivalent. > > This was requested by Jarkko. Okay, but why? Sounds to me like unneeded churn. Can't we do this later when required? -- With Best Regards, Andy Shevchenko