From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: "Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Jan Dabros" <jsd@semihalf.com>,
"Raag Jadav" <raag.jadav@intel.com>,
"Tauro, Riana" <riana.tauro@intel.com>,
"Adatrao, Srinivasa" <srinivasa.adatrao@intel.com>,
"Michael J. Ruhl" <michael.j.ruhl@intel.com>,
intel-xe@lists.freedesktop.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] i2c: designware: Add quirk for Intel Xe
Date: Tue, 1 Jul 2025 10:45:36 +0300 [thread overview]
Message-ID: <aGOSIB_H70IAWH3g@kuha.fi.intel.com> (raw)
In-Reply-To: <gljpd4foldjwairaca7ip2qqpdl7ipto77wsqwhbfamv6kdd3v@2doqwso7ccx3>
On Mon, Jun 30, 2025 at 08:28:12PM +0200, Andi Shyti wrote:
> Hi Heikki,
>
> On Fri, Jun 27, 2025 at 04:53:11PM +0300, Heikki Krogerus wrote:
> > The regmap is coming from the parent also in case of Xe
> > GPUs. Reusing the Wangxun quirk for that.
>
> What I don't like, though, is that there is no mention of the
> change in the probe in the commit log.
>
> Besides, are these changes related? Can we have them split in two
> different patches? I guess this would also make Andy's point
> about the extra churn.
I think you are right about splitting the patch. I'll do just that.
Thanks for the review Andi.
--
heikki
next prev parent reply other threads:[~2025-07-01 7:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 13:53 [PATCH v5 0/4] drm/xe: i2c support Heikki Krogerus
2025-06-27 13:53 ` [PATCH v5 1/4] i2c: designware: Add quirk for Intel Xe Heikki Krogerus
2025-06-27 14:13 ` Andy Shevchenko
2025-06-27 21:32 ` Rodrigo Vivi
2025-06-30 7:30 ` Andy Shevchenko
2025-06-30 8:10 ` Heikki Krogerus
2025-06-30 10:02 ` Andy Shevchenko
2025-06-30 11:59 ` Heikki Krogerus
2025-06-30 13:16 ` Andy Shevchenko
2025-06-30 14:16 ` Heikki Krogerus
2025-06-30 18:21 ` Andi Shyti
2025-06-30 18:28 ` Andi Shyti
2025-07-01 7:45 ` Heikki Krogerus [this message]
2025-06-27 13:53 ` [PATCH v5 2/4] drm/xe: Support for I2C attached MCUs Heikki Krogerus
2025-06-27 21:29 ` Rodrigo Vivi
2025-06-30 18:58 ` Andi Shyti
2025-06-27 13:53 ` [PATCH v5 3/4] drm/xe/pm: Wire up suspend/resume for I2C controller Heikki Krogerus
2025-06-30 18:59 ` Andi Shyti
2025-06-27 13:53 ` [PATCH v5 4/4] drm/xe/xe_i2c: Add support for i2c in survivability mode Heikki Krogerus
2025-06-30 19:02 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGOSIB_H70IAWH3g@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=airlied@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=michael.j.ruhl@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=raag.jadav@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=srinivasa.adatrao@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox