Re: [PATCH 2/7] i2c: qcom-cci: Add msm8953 compatible

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

Hi Luca,

> I'm also not sure what these parameters depend on, if it's CCI HW version,
> or
> something else. So naming it after the SoC should be a safer bet. Also the
> msm8974-cci was only named 'v1.5' because it's an inbetween mix of the v1
> and
> v2 that were already upstream so arguably that one shouldn't have been
> called
> v1.5 in the first place either.
> 
> Let me know what you think. Maybe also someone from Qualcomm/Linaro can jump
> in and share their thoughts, if someone knows more what these params depend
> on.

Thanks for the heads up. I agree that it needs someone from Qualcomm for
definite answers. But if nobody chimes in, your patch is good as is from
my side.

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]