From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87AA323CB for ; Mon, 8 Sep 2025 08:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757321217; cv=none; b=JIwz68ckdPgdDFEb85/Dga9RCmEy3QE309O91nrcTqDAvv71ZLi+1s8zS8nWtJYOQABpsmn1VEK/n1tRLa0v1LibIulGV/7ok17VpSW3uzZJkQkUnox4QkCznV+cteo+6MzK0ZzZlPJ5qlxNAkPQoYvfHxpp1rBUVXdT2GahcVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757321217; c=relaxed/simple; bh=Bj4f5uRY244iHB4rE4uWa8vhW6auxFTmI1aaD09pYy4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ruq9orjjCOTZ/Q9STSZxIbcTFrBlao28Z+TbpLj9shRzbc3TL6kou6i3kUNFJgJuujhxFPhybx9x4JokhUlsyH72Jvb1tW5oyo4Xn930tiQDRKuwPrk1EGiHGFnl91EHvm+01rsYdj4fOuLsETxDT1GrcqYVTpMMQ8K6vvPIhX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FP0eevmp; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FP0eevmp" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-62733e779bbso422466a12.1 for ; Mon, 08 Sep 2025 01:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757321214; x=1757926014; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IUopr+FL50FcSWn7mytwl0gX5Rr+3JnwzdeTq9mrxQQ=; b=FP0eevmpxMLL1QI9kUun0x+ZnATStLbZKIMV5RmbfA//BUKxCN46WaFPfXJklhEvWH d3OqiuCPiFkCD/SmqFx1DUzBTxeSfsFhKIN7nBGjD5NiUKWgKuRT4MsLHQmjc0vtsmyE iLbiIEeD3KiSfZmfCUOoE9RtkLVscQGxaG67yuRECdZrJYmeFn1o9VebwCRnaXhjFvMk gHTNuzXFeFVhBoXHGYxDOI+U3ko3LRy2XWtJbsHZALcS5sWHX2MWtEEVLprBBt9F+MAJ VfI1AjRxlIKZvrjhOgD8CO3gY2VGw7QMQ19oZRDnpe9G0yTMf2tsKWS65QarocXYULXR /WxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757321214; x=1757926014; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IUopr+FL50FcSWn7mytwl0gX5Rr+3JnwzdeTq9mrxQQ=; b=Q/adWaF3uGLMuvtZEoSFszx30gDJJ4JS2w6L2a7ekOHdCQyzysCIHKpgnpweEemaxo pFbMRXSalneTtYG679uFC7NN5SwvUCxviRuwlELkiJ6XU4gXoKRHEYB9y7wt0QNZenqH 48JMoqLsi28iu2VwMyp+cp/YAYCdbWa2FCkVNZpsCNgdRv6ZaiyjM3LB2hMd/SvqN257 O1Y4q458FkKowZ/fpIejuHwj+gSz33M6ucfMtxe6k5Lciox6j4Ihib1phlpL67Cf/gmp eh3AExbM9mpaWx7F3CPw7UI7utv0i+dympWwgZ5eHbx2/A6F8TiiClRFptONkCE6Vs/S MM2g== X-Forwarded-Encrypted: i=1; AJvYcCUmTL98iqy4IWfAXsktYfzGoehe2lVVI57X395yV3h9GEsW1OYAcVDY+HUtFAjHcZ3+AqKKOVMREt8=@vger.kernel.org X-Gm-Message-State: AOJu0YzO4DWIrrJpfdoI7Kyg2QCUse/EEfgGq2cEdBF6WUnfdwKmXrSq TMJp7bpm6YsQe0HuOnBz6xkTf8ZHSrJA4Q1xJSH0Nx2KHudxgy1DzljYOw0AWCsYeEY= X-Gm-Gg: ASbGncvavDGJsgCrN0ygolAr0/ye8VtTKabrx+dRhf2Bmo5U3/SetHOXOditWvLxkm0 NEFzx1nm3itld5CzEBRPneHlz9I8ipM11M5PtNVUzKn0OVDnvVKiHAMlzURg3gvpxcFLaE8lrQM 7hsrn5nZT+rpqHoZ3FPyzzl3/fOHsDXiBTsPRjCZ5tfBUrGs/Emp3woK+vsHH6fTmtc0ieq982t JLIsHb7IgobeYAEyQ3vR6Jm8GRcyq9uWrXHBq3ylPb3udRSaIQGIsECktusAaHZIYs86sr6QPfP aIGjEuR9VNyeVtgymwbyZXrKQPsXu5Jn0RZdD38ldImRIHzO+XSdP5bcc/zjAj6RBpDs6A37cy/ QHRDZCtTqv9faRbIPSMtx3D9c1hOU058nj02WH2p4dUt1RJzcmny1Jw== X-Google-Smtp-Source: AGHT+IGJq4/stKcb5/47RwYSY/9mKYvHfYIb+Y8TD1SuUTdb5c9q3HcwFqg/ndym+yPEqRaT8vxf8Q== X-Received: by 2002:a05:6402:52cb:b0:61a:967f:55f9 with SMTP id 4fb4d7f45d1cf-6237b972390mr6163555a12.10.1757321213876; Mon, 08 Sep 2025 01:46:53 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:30:1f60:42e1:1e1b:d240]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62343271613sm5201516a12.23.2025.09.08.01.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Sep 2025 01:46:53 -0700 (PDT) Date: Mon, 8 Sep 2025 10:46:49 +0200 From: Stephan Gerhold To: Konrad Dybcio Cc: Konrad Dybcio , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Loic Poulain , Robert Foss , Andi Shyti , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH 4/5] i2c: qcom-cci: Add OPP table support and enforce FAST_PLUS requirements Message-ID: References: <20250904-topic-cci_updates-v1-0-d38559692703@oss.qualcomm.com> <20250904-topic-cci_updates-v1-4-d38559692703@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Sep 08, 2025 at 10:43:50AM +0200, Konrad Dybcio wrote: > On 9/8/25 10:36 AM, Stephan Gerhold wrote: > > On Thu, Sep 04, 2025 at 04:31:23PM +0200, Konrad Dybcio wrote: > >> From: Konrad Dybcio > >> > >> The CCI clock has voltage requirements, which need to be described > >> through an OPP table. > >> > >> The 1 MHz FAST_PLUS mode requires the CCI core clock runs at 37,5 MHz > >> (which is a value common across all SoCs), since it's not possible to > >> reach the required timings with the default 19.2 MHz rate. > >> > >> Address both issues by introducing an OPP table and using it to vote > >> for the faster rate. > >> > >> Signed-off-by: Konrad Dybcio > > > > Using an OPP table for a single static rate that remains the same over > > the whole lifetime of the driver feels like overkill to me. Couldn't you > > just put the "required-opps" directly into the device node so that it is > > automatically applied when the device goes in/out of runtime suspend? > > > > And since you need to make DT additions anyway, couldn't you just use > > "assigned-clock-rates" to avoid the need for a driver patch entirely? We > > use that for e.g. USB clocks as well. > > This is futureproofing, in case someone invents FastMode++ with a higher > dvfs requirement or for when the driver adds presets for a 19.2 MHz CCI > clock which would (marginally) decrease power consumption > If 19.2 MHz CCI clock is feasible and has lower voltage requirements, then I would expect a separate entry for 19.2 MHz in the OPP table of PATCH 5/5? The DT is unrelated to what functionality you implement in the driver, and that would make the OPP table look less useless. :-) Thanks, Stephan