From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11156242925 for ; Wed, 3 Sep 2025 17:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756919731; cv=none; b=FR+b/PwLTbIu8fe1jlI5TDM5r/fWPex7ZX/dTYKAkCS2kEsOHpBUH6e7YVUUFMK0Z8K/JGTsjqqPB2Krn147cG5i5gP0f46q/zuSAitdysbRO4eg63shn6LNm0N0bpVkC4sLt6y8drAM0NlScH4rPsrghPd/WG6QLiPuhUK5na8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756919731; c=relaxed/simple; bh=jZUDx1Mx2eH40Dx2kMrnVR0J5IZIorEjpObTIAfvjDw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=omeDq60J63xMrzzuiiksZ2lyP6N8WTgzq5sTIU+fKmmkB740/XURNC5kflZQNjbHVdpt/3uVUJZqa0eBsOnauQtJ63dEw9Y0B/7xUGXMBuVyoVM98gUVLNvbvjVGWN3aTFPt4OtCgjraIRyL2MAH/h4zqnifd1xVdlmGhRAbyYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=NkSbxP55; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="NkSbxP55" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=78O4 dHWxeY4/54KjN6f8Acl6SIpWxsx4E4dnQG9eWXI=; b=NkSbxP55flzuHp/ecStL LIgl8x0F4bWQXeT5/YQ3ovJNl4iWzZcrMflOy8YtFqhnfsfHINDL/r7VO82D8S4B grhJ0U1FFzpVuJS4devnYCjYrW5y5LZC5LrhyOnBBySoUUXwm0V64LbM8cRZmR+B j+Gkyskdrz4Kr+vFL492bihQQcojluhUTDswlU5gwTxv2qeeB7US0K18i55qnKV7 1FKuxY8WXon26Udh7GPBdj6dJ+oV7q8KQVSoasJ2QRSAjA+UlYlw6ASMPF1f7RV/ fGN/JNYbmwR9HYTA7kZrgWZ/cdDcFlkMbhxqG0g/+8pZC4fC/cJO8T2xSqNkIZHA Qg== Received: (qmail 3373530 invoked from network); 3 Sep 2025 19:15:26 +0200 Received: by mail.zeus03.de with UTF8SMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 3 Sep 2025 19:15:26 +0200 X-UD-Smtp-Session: l3s3148p1@H9wowOg9GC9tKPO7 Date: Wed, 3 Sep 2025 19:15:25 +0200 From: Wolfram Sang To: Andi Shyti Cc: Cezar Chiru , peda@axentia.se, jdelvare@suse.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: Main i2c-*.c files and algos/ subdirectory : Fix errors and warnings generated by checkpatch Message-ID: References: <20250830093016.160753-1-chiru.cezar.89@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8rdk36Ry1vinCQMD" Content-Disposition: inline In-Reply-To: --8rdk36Ry1vinCQMD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 03, 2025 at 06:56:12PM +0200, Andi Shyti wrote: > Hi Cezar, >=20 > On Sat, Aug 30, 2025 at 12:30:15PM +0300, Cezar Chiru wrote: > > Fixed some coding style errors and warnings plus some minor changes > > in code as reported by checkpatch script. The busses/ and muxes/ > > subfolders will be dealt with another commit. Main changes were done > > to comments, defines of 'if' statement, swapping 'unsigned' with > > 'unsigned int' and other minor changes. > >=20 > > Signed-off-by: Cezar Chiru > > --- > > drivers/i2c/Kconfig | 2 +- > > drivers/i2c/algos/i2c-algo-bit.c | 29 +++++++++------ > > drivers/i2c/algos/i2c-algo-pca.c | 25 +++++++++---- > > drivers/i2c/algos/i2c-algo-pcf.c | 61 ++++++++++++++++++++++---------- > > drivers/i2c/algos/i2c-algo-pcf.h | 10 +++--- > > drivers/i2c/i2c-boardinfo.c | 2 +- > > drivers/i2c/i2c-core-base.c | 59 +++++++++++++++++++----------- > > drivers/i2c/i2c-dev.c | 47 ++++++++++++++---------- > > drivers/i2c/i2c-mux.c | 1 + > > drivers/i2c/i2c-slave-eeprom.c | 2 +- > > drivers/i2c/i2c-smbus.c | 2 +- > > drivers/i2c/i2c-stub.c | 29 +++++++-------- > > 12 files changed, 170 insertions(+), 99 deletions(-) >=20 > first of all, thanks for your patch, but I can't accept it. > Please split your patch in several smaller patches with single > changes. >=20 > Granularity is very important for reviews and git blame. Same comment as previous patch: describe testing please --8rdk36Ry1vinCQMD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmi4d60ACgkQFA3kzBSg KbYXHg/9GBXdVMFSHY1j6XfTKPGqNfmPBwuaje7q67ae9chO9Ib22fC3p6NyQTke WTCL3DqRtAWhy96xZ2uq7Qgh8PnzOWRRO6Ea3tQvRLojJufFLt8v8oj2qRFdM9vq dbPwp5nreFu/KvegEhrbNywkpGAdzxDYILa2Q4QVqLPFY1n8LPH18V+E2rIdRcnq QrcSpj6UloeV4QT0zfdnPa8LTAGOk8NHQN3LsP/qFLUGRLebZTKmgcFRrRtetmwN CBiaOYimobaqEP8gqo+PzL+UKI0AIYWRpYIOSOplPELdhXDY2uDHM8TxzhSPR+bK XgzwrFUxE64cWEgjuSRezpmir7KIa+YY2PN0a6HADLqAo0AKuuy0toT1a3eQuB9V o6kj3czOC8Vrlw0yhVFqT5nut9Wi+2DYsZRriik4jGV8a3gjAPMfUF1pMnV1QCNm uIfwSrKXaVTt0JL51RSrcgnRuI7FR6QDmbYy2KmF1qWbHqKHACwerpMNAW+pHey5 ekhXPN0vmXllDYfsHb4vHXTQa6sUg67Mth6a850LUiAZ6dM2oUooABLnuQ0zQYBG eZ6pRnsERjh3bpOt4NGxWssFNJCSqiqChJpXjb1kr6okJfJxFHJe2QgWQT9Jc3pP iPL7H4rsRa+XCyVr/tpGveCUKmD2chKBOCTu6dtBIqcbJQj+li8= =rNMb -----END PGP SIGNATURE----- --8rdk36Ry1vinCQMD--