From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Benoît Monin" <benoit.monin@bootlin.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Tawfik Bayouk <tawfik.bayouk@mobileye.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: use dev_err_probe when probing platform device
Date: Thu, 4 Sep 2025 12:49:36 +0300 [thread overview]
Message-ID: <aLlgsLDFvBGA7OZA@smile.fi.intel.com> (raw)
In-Reply-To: <aLlgRorNlvF1k2h9@smile.fi.intel.com>
On Thu, Sep 04, 2025 at 12:47:51PM +0300, Andy Shevchenko wrote:
> On Thu, Sep 04, 2025 at 10:59:24AM +0200, Benoît Monin wrote:
> > Add calls to dev_err_probe on error paths that can return -EPROBE_DEFER
Also add () to the function names or macros with parameters, i.e.
dev_err_probe()
> > when probing platform device. Namely when requesting the reset controller,
> > when probing for lock support and when requesting the clocks.
> >
> > In i2c_dw_probe_master and i2c_dw_probe_slave, called by the platform
i2c_dw_probe_master() and i2c_dw_probe_slave()
> > probe from i2c_dw_probe, replace the call to dev_err by dev_err_probe
i2c_dw_probe()
dev_err() by dev_err_probe()
> > when failing to acquire the IRQ.
> >
> > PCI device probing already use dev_err_probe.
dev_err_probe()
> What I see here is two patches:
> 1) conversion existing dev_err() to dev_err_probe();
> 2) adding messages to some of the plain return $ERR.
>
> Can you split with respective justification for each of them?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-09-04 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 8:59 [PATCH] i2c: designware: use dev_err_probe when probing platform device Benoît Monin
2025-09-04 9:47 ` Andy Shevchenko
2025-09-04 9:49 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLlgsLDFvBGA7OZA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=benoit.monin@bootlin.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).