From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C47382701DA for ; Thu, 4 Sep 2025 19:37:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757014641; cv=none; b=Jr3pY7LTUJSe8vfyC1lMKz7uuCItPxjxiDxraeRob8V+mIxQISZPOlXl/V2fpJnrOMM7VWTpAIfAFH0FBb9k7O8+EIlZpTd2KuZxR1MEr6I7Y69YTSOogYXxllXIysKZzQ4oAGa9pUJGmtJz0SoZJyvBuGALEgyqbe52mw8VgFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757014641; c=relaxed/simple; bh=1zQV/s94K5+h1YGZQMxFS9OiOGoj2u4JLZMij034Jf8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cyzR8jJSvxTFZu7CIAlZlR/ZaeKlqxNF1GBoCDWz97WZ5gc4x/a6rnx8IEMy8ePrwBLxmlLCJMph3jcIVL0/eBSbeoyZM6Nps+vKa6XrPulAe9WH9q4YhluoCmpJ7TRf8jLTvw30lada/Vb7gWuIMyE6C73z/xhxVzfW1rnpknw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jlg3M5QX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jlg3M5QX" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 584IB5jD003768 for ; Thu, 4 Sep 2025 19:37:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=McF2iXJTB0tw0p4n9n5WkRjm CGCLSHcRJu0PgH1a76w=; b=jlg3M5QXeLWp6cVDKBdqs6MOn5pkhdF00WH6DkWT hHmjLm8bkq10x6uamdNnRlTgwxF+viCZ3Huv5/2qTt82Fr2AiOWVDnLdSWD0U20d l3N2s6AQvK0U7i2ayG5jxamGjaqqKzRxxAX1V77hhS1lGpy8kB2vOm7+u2nwKdLP dY3nZYSxG5/aI9ghuT81Nr5pTiGdhcmFVTM3Ltiq/3Sn6K7tQLWpMN3gxhhoE7Fu rxt8nm/FQTVy00djexljCwo3be0iqspg+bn0c/7WhVei4VDHAT+c0UzAy6jwBKB6 B4NkLGp/mR4Hcg+7Gg2CQZaEeYKyZejXI61LeW81UoHwKw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48ur8s8rbh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 04 Sep 2025 19:37:18 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-248d9301475so21917155ad.0 for ; Thu, 04 Sep 2025 12:37:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757014638; x=1757619438; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=McF2iXJTB0tw0p4n9n5WkRjmCGCLSHcRJu0PgH1a76w=; b=v8Qy3J17JO+TGdktX7rdNBCBj9SJPPIEv7d64lIO8UDP9Ttuc1Zl+UBpls9MLheGat RzNPF+IBQQA16sUOimMqr0gbOOOWtzida4bC1Ra6NXubOgdg8m4gkdqKjAnda99dySUu tpCxefZ3uNIEjptjehFqGLoJ6eU8n0/hNp+kfbaNvtIn2NxImLL6Z3nVyQFAaHiJj3f+ /RUr/RyBr4IWxYwU2BCT4Yp07KnLdQoaAQH/rah1lsN/qZCCbJ1OgUJ7m3kDqYHaZrPN VGndy8/pVWViwqQB3Jo6Hh1g84UPjzt/3n/zBNUP6n8TUEzb1iY+UcUgdBZafYifP4IZ IgXQ== X-Forwarded-Encrypted: i=1; AJvYcCXQRaIHEPSmgOBCiLfUfSEZEzZ/42dEi0hGI1H+MtkhMRjox2Bi7XsOKPFFMdCf6Y0SXU8y55SwSQo=@vger.kernel.org X-Gm-Message-State: AOJu0YwdlllPCKTwXE2PXkBFYYNVXHjsjFi5cHs75H0PDtY8owHSOVJe rVnTvrL3jHjjWKfRAJDWsK8p+nMuC2WGW/sYLRZ1wUHO133lqhycqfWV4UZO5RhzQmPF+bokLI1 CmcIP1qwy7XKRuFvIf1fX9Ksi5J0IYs57zw07HN1n7lUfUFXUnm3+8FQQCPHmhtM= X-Gm-Gg: ASbGncvxrouQy22P01dO/tL3Z6wKA6GDlVaGjP70RdkE2y1U8URtIZ4NiUzZ9NMqNz2 2bAZGhKgymwV/vUr2KfSgKDJnJxjgEbV7zQoixWIdIH5vbs8+XGOR82A65QJFEG8uGgMM9rmMUJ tgPCd2epOKwITjFf5Qr/BFHcMATA3EBlQROaQSkwi0J8loDFbFzjKHQ9xssPwrbepe3SGSDEl/W ujCrE5sDC/io9J3Ufio+HqPPzv0w94MW+ExZDIQkl2O9a5dyhJhO5ySDFIGQHkHz7GuNhpKBTAr AjilxSpLVsi0sz5RCGBveo+rWS/AcRWg1eaBWRCcj5aO6dBczVWD4mea0ga4nIwETknR X-Received: by 2002:a17:903:ac3:b0:24c:a269:b6d7 with SMTP id d9443c01a7336-24ce9b57ba6mr14192435ad.50.1757014637696; Thu, 04 Sep 2025 12:37:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8wfQGHYpfVwabKJx2d0rjdTjkyrNxzu2OZBEviz2cswh6mp15XKTFFB6XMS1SDaXgiS2CFg== X-Received: by 2002:a17:903:ac3:b0:24c:a269:b6d7 with SMTP id d9443c01a7336-24ce9b57ba6mr14192115ad.50.1757014637195; Thu, 04 Sep 2025 12:37:17 -0700 (PDT) Received: from hu-wasimn-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24ccd655823sm20856515ad.114.2025.09.04.12.37.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Sep 2025 12:37:16 -0700 (PDT) Date: Fri, 5 Sep 2025 01:07:10 +0530 From: Wasim Nazir To: Dmitry Baryshkov Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Richard Cochran , Bartosz Golaszewski , kernel@oss.qualcomm.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v3 05/14] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C256C Message-ID: References: <20250904-lemans-evk-bu-v3-0-8bbaac1f25e8@oss.qualcomm.com> <20250904-lemans-evk-bu-v3-5-8bbaac1f25e8@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAxOSBTYWx0ZWRfX0BQl0Mo3XBdI x1gdoBF6EkeuxhRSlFeR2Jkzsebium31RaXHKt8tzf8DVAb4ynzg6hbIWWuA1Pgxn/jFqZVTfo8 +xIDkQVIXKl15pFU3wJxSv8bPNef7gOxwRLwE7U3t1eRuQy9ag5+BoW/1Wbb/dVHlZf2/A0pJFD Z+BptUP/GN4b3Kl2DwAHTB6lU9k5TtmTlt6AcPabLLY6qJX6urHAJTYe31t+HgzOYc7sqj3x++h vn+4wRVqIBPwp1J4OwSRNdDmNFiYlagIk/igqMkkPXeb3+/NOeC/35iGRmh4i/8E0Jk/Q+Ch5kf f9m+WYLzKllWzMmSvJMFqLvPUl7ysasSqxVumPBJrgIMCE8NntUo4b0hgEk8gu+omb82yjNr2a1 cZDGctlX X-Proofpoint-GUID: KnnuRIPQo6rncpNifCIJ2iwUsmUlegwJ X-Proofpoint-ORIG-GUID: KnnuRIPQo6rncpNifCIJ2iwUsmUlegwJ X-Authority-Analysis: v=2.4 cv=PNkP+eqC c=1 sm=1 tr=0 ts=68b9ea6e cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=IAxE5SYkeMM4qmkgMe8A:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-04_06,2025-09-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300019 On Thu, Sep 04, 2025 at 07:43:27PM +0300, Dmitry Baryshkov wrote: > On Thu, Sep 04, 2025 at 10:09:01PM +0530, Wasim Nazir wrote: > > Add the compatible for 256Kb EEPROM from Giantec. > > Why? Don't describe the change, describe the reason for the change. > Let me know if this properly describe the reason: --- dt-bindings: eeprom: at24: Add compatible for Giantec GT24C256C The gt24c256c is another 24c256 compatible EEPROM, and does not follow the generic name matching, so add a separate compatible for it. This ensures accurate device-tree representation and enables proper kernel support for systems using this part. --- > > > > Signed-off-by: Wasim Nazir > > --- > > Documentation/devicetree/bindings/eeprom/at24.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml > > index 0ac68646c077..50af7ccf6e21 100644 > > --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > > +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > > @@ -143,6 +143,7 @@ properties: > > - const: atmel,24c128 > > - items: > > - enum: > > + - giantec,gt24c256c > > - puya,p24c256c > > - const: atmel,24c256 > > - items: > > > > -- > > 2.51.0 > > > > -- > With best wishes > Dmitry -- Regards, Wasim