From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73D526B96A for ; Mon, 22 Sep 2025 14:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758552618; cv=none; b=A/3KyjgP+TJdcwTFg+J47zFB3Wc72WNykkQQVK4wIyxF7/FfYDZXI0NZdTasHd4pZRvglhCYBXnuWy/OBfkvdc6BriP4It75/JlhjNxzScwtgceb41QjLrSRg3D8G7wFJtKn1tW5xsgNpQ8PSATTnMGONvoYFpBqD0HP8GLFDSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758552618; c=relaxed/simple; bh=PJkfGbWQ8DKwLCLdQal42ea+EEF76F0Bpw81JJEN1eM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dE5tmnffReRVdtNrCTIOQQYwk0pnyynd4E5x/e+ZcvBLnrhhxAFQtHvhDc8NPu5m8A2lNjtVB5+5CUKlxS5VcUjWvZ/jLYpiHTDzvDY//+wHM+GSe8DZltA8bRHK41kxBo+jHv9ICbs9Vi9lqALBbQcihZSw6Ziwp9/vgqNAH2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OlCvPhXM; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OlCvPhXM" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-57a292a3a4bso3137068e87.3 for ; Mon, 22 Sep 2025 07:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758552615; x=1759157415; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PJkfGbWQ8DKwLCLdQal42ea+EEF76F0Bpw81JJEN1eM=; b=OlCvPhXMQrTHiVgolN4LwWr/VoY+H8xnlLyJr8IU5NvofmTriNS5gfKn53y4aHWORH P0T3PxAKsYHYbIRO/tvCP1bV7dP3+M6gOobowGt1HzNLw8OLBKHX1rG5IihLCyJRkfgY 1W3yWW7d8m/Gx3hMOsffmaugfPvUrMu9N6vrK/T3KtZAjgaQhdu3IGt1uxvEaIMpkiIf TzwjzFbbj0pInEv6aZyI2eCh4qmQcJz7SETbqBjGfXrKYCBgB5aQtEeg+31TayC+2GLC NWQCk1kTI07GkHxkxyG8iWVluQX+Yk8owOo30UwR+SxhnDio6ohd+CoOrb0XoX8vFkGL fmbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758552615; x=1759157415; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PJkfGbWQ8DKwLCLdQal42ea+EEF76F0Bpw81JJEN1eM=; b=nbgAFByiQQoNYQYvM6+b6kb3l4Q0qTJ3r+ukAqBm3xvii2CRrKNNKtEG9djzSb4cGZ Jgx8FL/sIp0dKIwfe0L4BTLWOykK5aaJDKkmOY1eBVlKfTOEhr0IxY0Sjp7PVeMQ4r2A ckJL5fjdp+23wGd03b1tjdH6E1iARH121bJ4SdcIk+hULvrVptYJFBtTzyIFHCGd7leX pUZksILYHnpEVAVMvpoyv2+RumEzcGj6+vscCFgqMkz/ZjTtYWkUiRY45xqgYzr7d0yN COCJUQE6wKLMJjWDsDbGZH2wmbUpWYUYVK+ow72c7HTxg3yrFmOS5MvmTBwGP0DhFycz ICOw== X-Forwarded-Encrypted: i=1; AJvYcCWLp6311QO5MU7GyTiT4AWrsf9GuqtRgWcoIw36l3H5BRdoHB6VcGVsz06/jJVnnPmzUP1IstZCsw8=@vger.kernel.org X-Gm-Message-State: AOJu0YwgwuiVIRgoigeXW9UtGmLLlVdGMp8dUZYpRTUHlkX4U4cE/ubI 9PEZPyxJBpX1HeI+0K0oYCdIVAl3JeROWEpcytREnTCCpCg/AOcjtijX X-Gm-Gg: ASbGncvF7irfsO/nXRrXJ86tW92/lXRwKq2amSBn4z1+4qMf/VyK4Zvbd0P8EJZJtZZ n88qH75bTqbb7S5IyelHQxfPAen13RG0GSM+gQJgpLbrC+IawRUesY/mQ3hZyx/gVTGmHzbXOwc RBbg+hBTxnpYkF+vsxEyPKVXdfuiMag29+8k02LKhH6NyZmNbAjvxHl9TAkR7ZIHj4itOAlpsia F/7NgR+4uSVybu+7CL49SImN4s+n667IVvV7fkp3f5qU7GUuDRsW8BIGmnNv7S4/zfra1kOCZhr wWvPsZvac9/KlVHrSoCKvTj6OLJkYo1TH/B8qfxGa8ZtPf9wVdm+iY9g3wmw5hpwrtZBShD0lpG 19g9fECw/Y7A180LOHZzPxI7W8AQ77qg2QwM5eZXD8M2No6sFTStmr7XIsuQ= X-Google-Smtp-Source: AGHT+IFcvDKfo6/rF+Nh3kI8hFqr1RyQcXaBGgCXhniYJNNce82tXdBX88O2hhL6GYKhS7xRDvOPEQ== X-Received: by 2002:a05:6512:2344:b0:57e:216b:7605 with SMTP id 2adb3069b0e04-57e216b7873mr1995745e87.49.1758552614400; Mon, 22 Sep 2025 07:50:14 -0700 (PDT) Received: from gmail.com (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-57ea29ee5ddsm890447e87.19.2025.09.22.07.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 07:50:13 -0700 (PDT) Date: Mon, 22 Sep 2025 16:50:11 +0200 From: Marcus Folkesson To: Bartosz Golaszewski Cc: Wolfram Sang , Peter Rosin , Michael Hennerich , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC 5/7] i2c: davinci: calculate bus freq from Hz instead of kHz Message-ID: References: <20250922-i2c-mux-v1-0-28c94a610930@gmail.com> <20250922-i2c-mux-v1-5-28c94a610930@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kLmsbuz1Pkyj0gi4" Content-Disposition: inline In-Reply-To: --kLmsbuz1Pkyj0gi4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Bartosz, On Mon, Sep 22, 2025 at 07:42:43AM -0700, Bartosz Golaszewski wrote: > On Mon, 22 Sep 2025 08:21:00 +0200, Marcus Folkesson > said: > > The bus frequency is unnecessarily converted between Hz and kHz in > > several places. > > This is probably an old legacy from the old times (pre-devicetrees) > > when the davinci_i2c_platform_data took the bus_freq in kHz. > > > > Stick to Hz. > > >=20 > This looks good but would you mind also changing the name of the field to > bus_freq_hz in order to leave zero change of misinterpreting it in the fu= ture? Thanks for your review! Sounds fair, I will change the name to bus_freq_hz in v2. >=20 > Bartosz Best regards, Marcus Folkesson --kLmsbuz1Pkyj0gi4 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAmjRYh4ACgkQiIBOb1ld UjIFaQ/+LAQ/eyJkvpFrJeZXJSpKHC7TjT/6INLurYa43ACv+OmVxYjnHFi6gpWi biuX98wrOiTY967DDBgQnlCAl72iirRfxCkImgv0HPg7MfeLiXarhLWwJzYbzp/2 h/3v2LB3wOJGw+OnWkiDCVXgpT5ti1ME/5S2cx1DAK1RrgCWJhPRzEF6mWWrXEvX hnrqSnf6OWFGN7SW2yegp0R5beRjKvZeI9Cg+A1x496RfRQKgEffQ6VxB50Y5iSx 4odYxRmVIEz9FSnWEhULeB77mgWT2F4vo0KokWd47MBznwwYDcIxtXnZMyW1Kqgb 0bPDZFqGnIvSQtgOo2tTiL7pAMvxncaWkvFMRmNFX+T+e8SjK0XyP+G0/IDETqoa T2k4HPloV4P0a5szKoIzvjaS+SlvMN5F+26XW9k/V9lP7GL+tOFFhy21CJArjU2L lRQ8SQLEIKu4JLs6RoVyOYiG+eFuwaaFTrzfBR1gULhMDrzBbT0k2nDrMjvWfGqI wsMHXrGqb6eWNq/Vx0sWV5BNLFl5vL38a9bXL0Gv6Lpmc2p7I9SSYcTe9eNR7nVK g2S8L/ivdCgXP/n9j1hmQrfACVKQec/DjxT9/HyXVwThXVUXso98DRdNOhZJyg5x letC7sGiSN1Pr+P2PAhHYYS33zg2kXad7jm0sHRM8zh89RCJsBg= =vtDu -----END PGP SIGNATURE----- --kLmsbuz1Pkyj0gi4--