From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Cezar Chiru <chiru.cezar.89@gmail.com>
Cc: andi.shyti@kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] i2c: pcf8584: Fix space(s) required before or after different operators
Date: Thu, 25 Sep 2025 12:35:53 +0200 [thread overview]
Message-ID: <aNUbCccy3wXadCox@shikoro> (raw)
In-Reply-To: <20250917133524.85063-4-chiru.cezar.89@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 439 bytes --]
On Wed, Sep 17, 2025 at 04:35:24PM +0300, Cezar Chiru wrote:
> Require spaces around or before or after '=', ';', '<' and ','.
> Add space(s) around or before or after binary and ternary operators and
> punctuation marks. Enforce errors fixing based on checkpatch.pl output on
> file.
>
> Signed-off-by: Cezar Chiru <chiru.cezar.89@gmail.com>
This patch is basically OK, but will become smaller if you remove the
DEB2 macro.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-09-25 10:35 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 11:45 [PATCH] i2c : algos : i2c-algo-pcf.c : fixed errors shown by checkpatch Cezar Chiru
2025-09-07 12:07 ` [PATCH v2] " Cezar Chiru
2025-09-07 13:19 ` Markus Elfring
2025-09-07 15:38 ` Cezar Chiru
2025-09-07 17:45 ` [PATCH v3] " Markus Elfring
2025-09-08 11:13 ` [PATCH 0/3] i2c : PCF8584 : Cover Letter Cezar Chiru
2025-09-08 11:13 ` [PATCH 1/3] i2c : pcf8584 : Fix debug macros defines of if statements Cezar Chiru
2025-09-08 12:44 ` Markus Elfring
2025-09-08 13:36 ` [PATCH v2 0/3] i2c: PCF8584: Cover letter Cezar Chiru
2025-09-08 13:36 ` [PATCH v2 1/3] i2c: PCF8584: Fix debug macros defines of if statements Cezar Chiru
2025-09-08 14:46 ` Markus Elfring
2025-09-08 15:42 ` Cezar Chiru
2025-09-08 17:08 ` [v2 " Markus Elfring
2025-09-08 17:58 ` [PATCH v3 0/3] i2c: PCF8584: Fix errors reported by checkpatch.pl Cezar Chiru
2025-09-08 17:59 ` [PATCH v3 1/3] i2c: PCF8584: Fix debug macros defines of if statements Cezar Chiru
2025-09-08 19:18 ` Markus Elfring
2025-09-08 17:59 ` [PATCH v3 2/3] i2c: PCF8584: Fix do not use assignment in if conditional Cezar Chiru
2025-09-08 17:59 ` [PATCH v3 3/3] i2c: PCF8584: Fix space(s) required before or after different operators Cezar Chiru
2025-09-09 7:30 ` Markus Elfring
2025-09-09 8:18 ` Cezar Chiru
2025-09-08 13:36 ` [PATCH v2 2/3] i2c: PCF8584: Fix do not use assignment in 'if' conditional Cezar Chiru
2025-09-08 13:36 ` [PATCH v2 3/3] i2c: PCF8584: Fixed space(s) required after different operators Cezar Chiru
2025-09-08 11:13 ` [PATCH 2/3] i2c : PCF8584 : Fix do not use assignment in 'if' conditional Cezar Chiru
2025-09-08 11:13 ` [PATCH 3/3] i2c : PCF8584 : Fixed space required after different operators Cezar Chiru
2025-09-17 13:35 ` [PATCH v4 0/3] i2c: pcf8584: Fix errors reported by checkpatch.pl Cezar Chiru
2025-09-17 13:35 ` [PATCH v4 1/3] i2c: pcf8584: Fix debug macros defines of if statements Cezar Chiru
2025-09-25 10:35 ` Wolfram Sang
2025-09-25 11:56 ` Cezar Chiru
2025-09-26 15:45 ` [PATCH v5 0/3] i2c: pcf8584: Fix errors reported by checkpatch Cezar Chiru
2025-09-26 15:45 ` [PATCH v5 1/3] i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c Cezar Chiru
2025-09-26 18:07 ` Wolfram Sang
2025-09-26 19:05 ` Cezar Chiru
2025-09-27 4:13 ` [PATCH v6 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch Cezar Chiru
2025-09-27 4:13 ` [PATCH v6 1/3] i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c Cezar Chiru
2025-10-17 20:47 ` Andi Shyti
2025-09-27 4:13 ` [PATCH v6 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Cezar Chiru
2025-09-27 4:14 ` [PATCH v6 3/3] i2c: pcf8584: Fix space(s) required before or after different operators Cezar Chiru
2025-10-17 20:58 ` Andi Shyti
2025-10-17 20:39 ` [PATCH v6 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch Andi Shyti
2025-09-26 15:45 ` [PATCH v5 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Cezar Chiru
2025-09-26 15:45 ` [PATCH v5 3/3] i2c: pcf8584: Fix space(s) required before or after different operators Cezar Chiru
2025-10-16 16:14 ` [PATCH v6 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch Cezar Chiru
2025-10-16 16:14 ` [PATCH v6 1/3] i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c Cezar Chiru
2025-10-16 16:14 ` [PATCH v6 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Cezar Chiru
2025-10-16 16:14 ` [PATCH v6 3/3] i2c: pcf8584: Fix space(s) required before or after different operators Cezar Chiru
2025-09-17 13:35 ` [PATCH v4 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Cezar Chiru
2025-09-25 10:35 ` Wolfram Sang
2025-09-17 13:35 ` [PATCH v4 3/3] i2c: pcf8584: Fix space(s) required before or after different operators Cezar Chiru
2025-09-25 10:35 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNUbCccy3wXadCox@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=chiru.cezar.89@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).