From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: "Benoît Monin" <benoit.monin@bootlin.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Tawfik Bayouk <tawfik.bayouk@mobileye.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: designware: convert to dev_err_probe() on request IRQ error
Date: Thu, 25 Sep 2025 23:35:12 +0200 [thread overview]
Message-ID: <aNW1kP-jJquffypg@shikoro> (raw)
In-Reply-To: <20250904-i2c-dw-dev-err-probe-v2-1-e59da34815fa@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Thu, Sep 04, 2025 at 04:31:06PM +0200, Benoît Monin wrote:
> Simplify the error handling of devm_request_irq() in
> i2c_dw_probe_master() and i2c_dw_probe_slave() by converting to:
>
> return dev_err_probe();
>
> instead of calling:
>
> dev_err();
> return ret;
>
> This also handle deferred probe error without spamming the log.
>
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-09-25 21:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 14:31 [PATCH v2 0/2] Add dev_err_probe() to i2c designware platform probing Benoît Monin
2025-09-04 14:31 ` [PATCH v2 1/2] i2c: designware: convert to dev_err_probe() on request IRQ error Benoît Monin
2025-09-04 15:02 ` Andy Shevchenko
2025-09-05 8:04 ` Jarkko Nikula
2025-09-25 21:35 ` Wolfram Sang [this message]
2025-09-04 14:31 ` [PATCH v2 2/2] i2c: designware: use dev_err_probe() when probing platform device Benoît Monin
2025-09-04 15:04 ` Andy Shevchenko
2025-09-05 8:04 ` Jarkko Nikula
2025-09-25 21:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNW1kP-jJquffypg@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benoit.monin@bootlin.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox