From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Cezar Chiru <chiru.cezar.89@gmail.com>
Cc: andi.shyti@kernel.org, wsa+renesas@sang-engineering.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/3] i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret < 0.
Date: Thu, 23 Oct 2025 21:34:29 +0300 [thread overview]
Message-ID: <aPp1NRDgBwemLfs1@smile.fi.intel.com> (raw)
In-Reply-To: <20251023120043.8661-2-chiru.cezar.89@gmail.com>
On Thu, Oct 23, 2025 at 03:00:41PM +0300, Cezar Chiru wrote:
> Require spaces around '=' and '<'. Add spaces around binary operators.
> Enforce error fixing based on checkpatch.pl output on file.
> Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This
> improves usage of ret variable.
...
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
I haven't suggested much, but if you insist in the tag I won't object.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-23 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 12:00 [PATCH v9 0/3] Improve usage of 'ret' variable and make pcf_doAdress() void Cezar Chiru
2025-10-23 12:00 ` [PATCH v9 1/3] i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret < 0 Cezar Chiru
2025-10-23 18:34 ` Andy Shevchenko [this message]
2025-10-24 10:57 ` Andi Shyti
2025-10-24 13:55 ` Cezar Chiru
2025-10-27 16:28 ` Andi Shyti
2025-10-23 12:00 ` [PATCH v9 2/3] i2c: pcf8584: Make pcf_doAddress() function void Cezar Chiru
2025-10-23 12:00 ` [PATCH v9 3/3] i2c: pcf8584: Change pcf_doAdress() to pcf_send_address() Cezar Chiru
2025-10-28 17:39 ` [PATCH v9 0/3] Improve usage of 'ret' variable and make pcf_doAdress() void Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPp1NRDgBwemLfs1@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andi.shyti@kernel.org \
--cc=chiru.cezar.89@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox