Re: [PATCH] i2c: muxes: pca954x: Fix broken reset-gpio usage

Wolfram Sang
2025-11-03T15:48:24Z

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

> Maybe I should also add to emphasize:
>
> That offending commit 690de2902dca breaks the ABI which was:
> 1. documented at
> Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml (line 57)
> 2. implemented in Linux kernel around v3.14.
>
> This ABI breakage was not justified at all, not explained not even
> mentioned in the commit msg, which is a requirement (see writing
> bindings document).

We were under the assumption that the reset-core will provide exactly
the same functionality at a centralized place. It made sense to me, too,
to avoid all the open-coded reset-gpio handlings in various drivers. I
only learnt from Morimoto-san's regression report that things were not
as I thought.

So, I sent out an RFC to discuss how to handle this issue. And if even
Philipp as the maintainer did not point me directly to revert the
offending i2c-mux commit, despite it is "obviously" sooo wrong, then
probably that optional fallback part in the reset-core needs way more
explanations and documentation.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]