From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Peter Rosin <peda@axentia.se>,
Philipp Zabel <p.zabel@pengutronix.de>,
Wojciech Siudy <wojciech.siudy@nokia.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: muxes: pca954x: Fix broken reset-gpio usage
Date: Mon, 3 Nov 2025 18:05:50 +0100 [thread overview]
Message-ID: <aQjg7uQyXMCSULy2@shikoro> (raw)
In-Reply-To: <20251103151905.297014-2-krzysztof.kozlowski@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
On Mon, Nov 03, 2025 at 04:19:06PM +0100, Krzysztof Kozlowski wrote:
> Revert commit 690de2902dca ("i2c: muxes: pca954x: Use reset controller
> only") and its dependent commit 94c296776403 ("i2c: muxes: pca954x:
> Reset if (de)select fails") because the first breaks all users of the
> driver, by requiring a completely optional reset-gpio driver. These
> commits cause that mux driver simply stops working when optional
> reset-gpio is not included, but that reset-gpio is not pulled anyhow.
>
> Driver cannot remove legacy reset-gpios handling.
>
> Fixes: 690de2902dca ("i2c: muxes: pca954x: Use reset controller only")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-11-03 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 15:19 [PATCH] i2c: muxes: pca954x: Fix broken reset-gpio usage Krzysztof Kozlowski
2025-11-03 15:36 ` Krzysztof Kozlowski
2025-11-03 15:48 ` Wolfram Sang
2025-11-03 17:05 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQjg7uQyXMCSULy2@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=wojciech.siudy@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).