From: Andi Shyti <andi.shyti@kernel.org>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: p.zabel@pengutronix.de, andriy.shevchenko@linux.intel.com,
jsd@semihalf.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com
Subject: Re: [PATCH v4] i2c: designware-platdrv: simplify reset control and error handling
Date: Tue, 20 Jan 2026 14:55:29 +0100 [thread overview]
Message-ID: <aW-IlK4GXnJlVxpB@zenone.zhora.eu> (raw)
In-Reply-To: <20251111145536.3232456-1-a.shimko.dev@gmail.com>
Hi Artem,
I'm sorry, but in one thread there are three versions and I don't
really know what you are addressing. May I ask you to resend it
without linking it to any thread (please don't use in-reply-to).
On Tue, Nov 11, 2025 at 05:55:36PM +0300, Artem Shimko wrote:
> The current implementation uses separate calls to acquire and deassert
> reset control, requiring manual error handling for the deassertion
> operation. This can be simplified using the dedicated devm function that
> combines both operations.
>
> Replace devm_reset_control_get_optional_exclusive() with
> devm_reset_control_get_optional_exclusive_deasserted(), which handles both
> reset acquisition and deassertion in a single call as well as
> reset_control_put() which is called automatically on driver detach. This
> eliminates the need for explicit deassertion and its associated error
> checking while maintaining the same functional behavior through automatic
> resource management.
>
> As part of this cleanup, streamline the error handling by removing goto
> exit_reset and goto exit_probe labels, using direct returns with
> dev_err_probe() for cleaner and more linear code flow.
Can you please put this part in a separate patch? They are
logically unrelated.
Thanks,
Andi
next prev parent reply other threads:[~2026-01-20 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 7:53 [PATCH RESEND] i2c: designware-platdrv: handle reset control deassert error Artem Shimko
2025-11-11 9:15 ` Philipp Zabel
2025-11-11 11:45 ` [PATCH v2 1/3] i2c: designware-platdrv: simplify reset control with devm variant Artem Shimko
2025-11-11 11:45 ` [PATCH v2 2/3] i2c: designware-platdrv: complete reset control devm conversion Artem Shimko
2025-11-11 12:43 ` Philipp Zabel
2025-11-11 14:09 ` [PATCH v3] i2c: designware-platdrv: simplify reset control and error handling Artem Shimko
2025-11-11 14:33 ` Philipp Zabel
2025-11-11 14:33 ` [PATCH v2 2/3] i2c: designware-platdrv: complete reset control devm conversion Philipp Zabel
2025-11-11 14:55 ` [PATCH v4] i2c: designware-platdrv: simplify reset control and error handling Artem Shimko
2026-01-20 13:55 ` Andi Shyti [this message]
2025-11-11 11:45 ` [PATCH v2 3/3] i2c: designware-platdrv: streamline " Artem Shimko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW-IlK4GXnJlVxpB@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=a.shimko.dev@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox