From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] i2c: core: Check for error pointer for fwnode
Date: Tue, 13 Jan 2026 17:25:30 +0100 [thread overview]
Message-ID: <aWZx-l3YPHRdtljl@ninjato> (raw)
In-Reply-To: <20260112132346.4087258-2-andriy.shevchenko@linux.intel.com>
On Mon, Jan 12, 2026 at 02:22:40PM +0100, Andy Shevchenko wrote:
> Theoretically it's possible that fwnode is returned by some API,
> that may return an error pointer (and we have, for example,
> fwnode_find_reference() which does that). If such an fwnode
> is supplied to the i2c core APIs the functions will perform
> unneeded loops and checks. Avoid this by preventively checking
> for an error pointer and bail out immediately.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to for-next, thanks!
next prev parent reply other threads:[~2026-01-13 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 13:22 [PATCH v1 0/3] i2c: core: Tidy up fwnode handling Andy Shevchenko
2026-01-12 13:22 ` [PATCH v1 1/3] i2c: core: Check for error pointer for fwnode Andy Shevchenko
2026-01-13 16:25 ` Wolfram Sang [this message]
2026-01-12 13:22 ` [PATCH v1 2/3] i2c: core: Replace custom implementation of device_match_fwnode() Andy Shevchenko
2026-01-13 16:25 ` Wolfram Sang
2026-01-12 13:22 ` [PATCH v1 3/3] i2c: core: Use dev_fwnode() Andy Shevchenko
2026-01-13 16:25 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWZx-l3YPHRdtljl@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox