From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicola Corna" Subject: Re: [PATCH v4 4/4] iio: humidity: si7020: added No Hold read mode Date: Wed, 28 Oct 2015 18:35:17 +0000 Message-ID: References: <5630977D.2020102@metafoo.de> <1446015506-21371-1-git-send-email-nicola@corna.info> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: Received: from 1.mo2.mail-out.ovh.net ([46.105.63.121]:53691 "EHLO 1.mo2.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752821AbbJ1Sfq convert rfc822-to-8bit (ORCPT ); Wed, 28 Oct 2015 14:35:46 -0400 Received: from mail435.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo2.mail-out.ovh.net (Postfix) with SMTP id 952E1FFCA5E for ; Wed, 28 Oct 2015 19:35:40 +0100 (CET) In-Reply-To: <5630977D.2020102@metafoo.de> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Lars-Peter Clausen , Wolfram Sang , Stephen Warren , Lee Jones , Eric Anholt , Jonathan Cameron Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hartmut Knaack , Peter Meerwald , linux-iio@vger.kernel.org October 28 2015 10:38 AM, "Lars-Peter Clausen" wrote: > On 10/28/2015 07:58 AM, Nicola Corna wrote: > [...] > >> + holdmode = !((*client)->adapter->quirks && >> + (*client)->adapter->quirks->flags & > > [...] > >> + client->adapter->quirks && >> + client->adapter->quirks->flags & I2C_AQ_NO_CLK_STRETCH) > > This is rather ugly, can we get a helper in the I2C core something along the > lines of > > i2c_check_quirks(client->adapter, I2C_AQ_NO_CLK_STRETCH) > > - Lars Something like this? --- diff --git a/include/linux/i2c.h b/include/linux/i2c.h index a69a9a0..a06ffc0 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -613,6 +613,12 @@ static inline int i2c_check_functionality(struct i2c_adapter *adap, u32 func) return (func & i2c_get_functionality(adap)) == func; } +/* Return 1 if adapter has the specified quirks, 0 if not. */ +static inline int i2c_check_quirks(struct i2c_adapter *adap, u64 quirks) +{ + return (quirks & (adap->quirks ? adap->quirks->flags : 0)) == quirks; +} + /* Return the adapter number for a specific adapter */ static inline int i2c_adapter_id(struct i2c_adapter *adap) {