public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Shyam Sundar S K <shyam-sundar.s-k@amd.com>,
	Nirujogi Pratap <pratap.nirujogi@amd.com>,
	Bin Du <bin.du@amd.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Hans Hu <hanshu@zhaoxin.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH v2 0/4] i2c: provide and use i2c_adapter_dev()
Date: Thu, 26 Feb 2026 21:23:18 +0100	[thread overview]
Message-ID: <aaCrtsNpTPeXDYnT@ninjato> (raw)
In-Reply-To: <20260223-i2c-adapter-dev-wrapper-v2-0-d02946569773@oss.qualcomm.com>

On Mon, Feb 23, 2026 at 10:02:48AM +0100, Bartosz Golaszewski wrote:
> It's been another year of discussing the object life-time problems at
> conferences. I2C is one of the offenders and its problems are more
> complex than those of some other subsystems. It seems the revocable[1]
> API may make its way into the kernel this year but even with it in
> place, I2C won't be able to use it as there's currently nothing to
> *revoke*. The struct device is embedded within the i2c_adapter struct
> whose lifetime is tied to the provider device being bound to its driver.
> 
> Fixing this won't be fast and easy but nothing's going to happen if we
> don't start chipping away at it. The ultimate goal in order to be able
> to use an SRCU-based solution (revocable or otherwise) is to convert the
> embedded struct device in struct i2c_adapter into an __rcu pointer that
> can be *revoked*. To that end we need to hide all dereferences of
> adap->dev in drivers.
> 
> Other series address more generic problems - like printk helpers and
> parent/of_node setting - but there are still some more specific
> use-cases of drivers dereferencing the internal struct device of
> i2c_adapters. We need to hide the fact that the device is embedded in
> i2c_adapter before we can move it out so provide a helper that provides
> the address of struct device without showing how it's stored and use it
> in some drivers.
> 
> Link: [1] https://lore.kernel.org/all/20251106152330.11733-1-tzungbi@kernel.org/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Also applied to for-current and squashed everything into one patch...

> ---
> Changes in v2:
> - drop two patches that can be addressed in a different series
> - rebase on top of v7.0-rc1

... but why didn't you rebase on top of rc1 + plus your previous series?
The merge conflict was easy to solve but kinda unnecessary in my
book...?


      parent reply	other threads:[~2026-02-26 20:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23  9:02 [PATCH v2 0/4] i2c: provide and use i2c_adapter_dev() Bartosz Golaszewski
2026-02-23  9:02 ` [PATCH v2 1/4] i2c: provide i2c_adapter_dev() Bartosz Golaszewski
2026-02-23  9:02 ` [PATCH v2 2/4] i2c: piix4: use i2c_adapter_dev() Bartosz Golaszewski
2026-02-23  9:02 ` [PATCH v2 3/4] i2c: amd-asf-plat: " Bartosz Golaszewski
2026-02-23  9:02 ` [PATCH v2 4/4] i2c: mv64xxx: " Bartosz Golaszewski
2026-02-23  9:13   ` Andy Shevchenko
2026-02-23  9:23     ` Bartosz Golaszewski
2026-02-23 11:37       ` Andy Shevchenko
2026-02-23  9:15 ` [PATCH v2 0/4] i2c: provide and " Andy Shevchenko
2026-02-26 20:23 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaCrtsNpTPeXDYnT@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=bin.du@amd.com \
    --cc=brgl@kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=hanshu@zhaoxin.com \
    --cc=jdelvare@suse.com \
    --cc=jdelvare@suse.de \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=pratap.nirujogi@amd.com \
    --cc=shyam-sundar.s-k@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox