From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
Lixu Zhang <lixu.zhang@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Israel Cepeda <israel.a.cepeda.lopez@intel.com>,
Hans de Goede <hansg@kernel.org>,
Nirujogi Pratap <pratap.nirujogi@amd.com>,
Bin Du <bin.du@amd.com>, Hans Hu <hanshu@zhaoxin.com>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 0/9] i2c: provide and use i2c_adapter_set_node()
Date: Thu, 26 Feb 2026 21:25:42 +0100 [thread overview]
Message-ID: <aaCsRr7eT3AA_5sq@ninjato> (raw)
In-Reply-To: <20260223-i2c-ada-dev-set-node-v2-0-77018c536610@oss.qualcomm.com>
On Mon, Feb 23, 2026 at 10:08:18AM +0100, Bartosz Golaszewski wrote:
> It's been another year of discussing the object life-time problems at
> conferences. I2C is one of the offenders and its problems are more
> complex than those of some other subsystems. It seems the revocable[1]
> API may make its way into the kernel this year but even with it in
> place, I2C won't be able to use it as there's currently nothing to
> *revoke*. The struct device is embedded within the i2c_adapter struct
> whose lifetime is tied to the provider device being bound to its driver.
>
> Fixing this won't be fast and easy but nothing's going to happen if we
> don't start chipping away at it. The ultimate goal in order to be able
> to use an SRCU-based solution (revocable or otherwise) is to convert the
> embedded struct device in struct i2c_adapter into an __rcu pointer that
> can be *revoked*. To that end we need to hide all dereferences of
> adap->dev in drivers.
>
> I2C drivers use device_set_node() to assign a firmware node directly to
> the struct device embedded in i2c_adapter. In order to hide the direct
> dereferencing: provide a dedicated interface that wraps the call to
> device_set_node() but takes the adapter as argument instead.
>
> Link: https://lore.kernel.org/all/20251106152330.11733-1-tzungbi@kernel.org/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Applied to for-current, squashed...
> ---
> Changes in v2:
> - add patches replacing ACPI_COMPANION_SET() with i2c_adapter_set_node()
> - rebased on top of v7.0-rc1
... and resolved another merge conflict :/
But despite this minor hickup, thanks a ton for your work! Looking
forward to your follow-up patches.
Happy hacking!
prev parent reply other threads:[~2026-02-26 20:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 9:08 [PATCH v2 0/9] i2c: provide and use i2c_adapter_set_node() Bartosz Golaszewski
2026-02-23 9:08 ` [PATCH v2 1/9] i2c: provide i2c_adapter_set_node() Bartosz Golaszewski
2026-02-23 9:08 ` [PATCH v2 2/9] i2c: designware-common: use i2c_adapter_set_node() Bartosz Golaszewski
2026-02-23 9:08 ` [PATCH v2 3/9] i2c: gpio: " Bartosz Golaszewski
2026-02-23 9:08 ` [PATCH v2 4/9] i2c: ljca: " Bartosz Golaszewski
2026-02-23 9:08 ` [PATCH v2 5/9] i2c: ls2x: " Bartosz Golaszewski
2026-02-23 9:08 ` [PATCH v2 6/9] i2c: rzv2m: " Bartosz Golaszewski
2026-02-23 9:08 ` [PATCH v2 7/9] i2c: usbio: " Bartosz Golaszewski
2026-02-23 9:08 ` [PATCH v2 8/9] i2c: designware-amdisp: " Bartosz Golaszewski
2026-02-23 11:46 ` Andy Shevchenko
2026-02-23 12:23 ` Bartosz Golaszewski
2026-02-26 20:24 ` Wolfram Sang
2026-02-23 9:08 ` [PATCH v2 9/9] i2c: viai2c-zhaoxin: " Bartosz Golaszewski
2026-02-26 20:25 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaCsRr7eT3AA_5sq@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bin.du@amd.com \
--cc=brgl@kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=hansg@kernel.org \
--cc=hanshu@zhaoxin.com \
--cc=israel.a.cepeda.lopez@intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pratap.nirujogi@amd.com \
--cc=sakari.ailus@linux.intel.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox