From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
mika.westerberg@linux.intel.com, wsa@the-dreams.de,
linux-i2c@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: designware: Fix bogus sda_hold_time due to uninitialized vars
Date: Mon, 22 May 2017 09:37:13 +0300 [thread overview]
Message-ID: <aad364b9-75ce-553e-28da-a5458b90b332@linux.intel.com> (raw)
In-Reply-To: <743ebd23-17ab-03d2-ebd9-66acc9aee417@siemens.com>
On 05/22/2017 08:46 AM, Jan Kiszka wrote:
> We need to initializes those variables to 0 for platforms that do not
> provide ACPI parameters. Otherwise, we set sda_hold_time to random
> values, breaking e.g. Galileo and IOT2000 boards.
>
> Fixes: 9d6408433019 ("i2c: designware: don't infer timings described by ACPI from clock rate")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> Affects 4.12-rc2.
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2017-05-22 6:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 8:56 [PATCH] i2c: designware: don't infer timings described by ACPI from clock rate Ard Biesheuvel
2017-05-19 10:01 ` Jarkko Nikula
2017-05-19 10:06 ` Ard Biesheuvel
2017-05-19 10:37 ` Jarkko Nikula
2017-05-19 10:48 ` Ard Biesheuvel
2017-05-19 12:38 ` Wolfram Sang
2017-05-21 8:09 ` Ard Biesheuvel
2017-05-22 5:44 ` Jan Kiszka
2017-05-22 6:35 ` Jarkko Nikula
2017-05-22 5:46 ` [PATCH] i2c: designware: Fix bogus sda_hold_time due to uninitialized vars Jan Kiszka
2017-05-22 6:02 ` Ard Biesheuvel
2017-05-22 6:37 ` Jarkko Nikula [this message]
2017-05-22 8:36 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aad364b9-75ce-553e-28da-a5458b90b332@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).