Re: [PATCH] i2c: Do not give adapters a default parent

[Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>]

On Tue, Jul 28, 2009 at 08:47, Jean Delvare<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
>
> What's the merge timeline for this patch?

I just did it in the moment you asked, there are no other users so
far. Just submit it with your changes that need it, if Greg is ok with
that?

>> > Other than that (and in practice even with that) your patch works just
>> > fine for me. Thanks! Unfortunately it doesn't provide perfect
>> > compatibility, [...] to add this device link (pointing to "..") temporarily
>> > or would that be too confusing?
>>
>> I think that's ok, if it solves a real problem. The entire idea of _a_
>> "device" link is pretty flawed, and the reason we ripped all the
>> "struct class_device" devices out.
>
> OK, I've added the "device" link and now compatibility works perfectly.
> I'll post the updated patch series soon, if you want to take a look.

Sounds great.

> Would it make sense to move the "device" link creation into
> class_compat_create_link()? I suspect other users of a compatibility
> class may need it as well.

Might make sense, as long as it's not the built-in default.

Sometimes we need to insert devices into the devpath, and then the
"device" link does not point to the direct parent, but the next one.
So it would need to take another device parameter, if we do that, and
also accept NULL, if no such link is really needed.

The "device" link itself is a pretty broken concept, and should be
avoided wherever possible, so it should be as optional as we can do
it. :)

Thanks,
Kay