Re: [PATCH 07/10] ARM: PNX4008: move i2c suspend/resume callbacks into driver

From: Vitaly Wool <vitalywool@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
	Kevin Wells <kevin.wells@nxp.com>
Subject: Re: [PATCH 07/10] ARM: PNX4008: move i2c suspend/resume callbacks into driver
Date: Mon, 23 Nov 2009 21:22:44 +0300	[thread overview]
Message-ID: <acd2a5930911231022i60eda84di12799fb4a55faab9@mail.gmail.com> (raw)
In-Reply-To: <20091121125347.GE7998@n2100.arm.linux.org.uk>

[-- Attachment #1.1: Type: text/plain, Size: 1022 bytes --]

On Sat, Nov 21, 2009 at 3:53 PM, Russell King - ARM Linux <
linux@arm.linux.org.uk> wrote:

> On Fri, Nov 20, 2009 at 10:50:34AM +0000, Russell King - ARM Linux wrote:
> > -static int i2c_pnx_suspend(struct platform_device *pdev, pm_message_t
> state)
> > -{
> > -     int retval = 0;
> > -#ifdef CONFIG_PM
> > -     retval = set_clock_run(pdev);
> > -#endif
>
> BTW, a comment from PNX folk (Vitaly/Kevin) would be appreciated.  Why
> does PNX enable the clock when going into suspend?  Should I assume that
> this should actually be disabling the clock?
>

As far as I recall, at some point there was a function that was taking the
second boolean parameter (enable or disable the clock). So now it is, yes,
not making much sense.

> Also, if Vitaly doesn't have anything to do with PNX4008 anymore, it
> would be a good idea to update the MAINTAINERS file.
>

I'd like to keep maintaining this platform, but it's also up to NXP because
I don't have the actual working hardware now so there's not much I can do.

Vitaly

[-- Attachment #1.2: Type: text/html, Size: 1548 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel