From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Wool Subject: Re: [PATCH 07/10] ARM: PNX4008: move i2c suspend/resume callbacks into driver Date: Mon, 23 Nov 2009 21:22:44 +0300 Message-ID: References: <20091120144422.GA18223@n2100.arm.linux.org.uk> <20091121125347.GE7998@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0751528294==" Return-path: In-Reply-To: <20091121125347.GE7998@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, Kevin Wells List-Id: linux-i2c@vger.kernel.org --===============0751528294== Content-Type: multipart/alternative; boundary=0016e6d77eac72cecb04790de966 --0016e6d77eac72cecb04790de966 Content-Type: text/plain; charset=ISO-8859-1 On Sat, Nov 21, 2009 at 3:53 PM, Russell King - ARM Linux < linux@arm.linux.org.uk> wrote: > On Fri, Nov 20, 2009 at 10:50:34AM +0000, Russell King - ARM Linux wrote: > > -static int i2c_pnx_suspend(struct platform_device *pdev, pm_message_t > state) > > -{ > > - int retval = 0; > > -#ifdef CONFIG_PM > > - retval = set_clock_run(pdev); > > -#endif > > BTW, a comment from PNX folk (Vitaly/Kevin) would be appreciated. Why > does PNX enable the clock when going into suspend? Should I assume that > this should actually be disabling the clock? > As far as I recall, at some point there was a function that was taking the second boolean parameter (enable or disable the clock). So now it is, yes, not making much sense. > Also, if Vitaly doesn't have anything to do with PNX4008 anymore, it > would be a good idea to update the MAINTAINERS file. > I'd like to keep maintaining this platform, but it's also up to NXP because I don't have the actual working hardware now so there's not much I can do. Vitaly --0016e6d77eac72cecb04790de966 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Sat, Nov 21, 2009 at 3:53 PM, Russell King - = ARM Linux <l= inux@arm.linux.org.uk> wrote:
On Fri, Nov 20, 2009 at 10:50:34AM +0000, Russell King - = ARM Linux wrote:
> -static int i2c_pnx_suspend(struct platform_device *pdev, pm_message_t= state)
> -{
> - =A0 =A0 int retval =3D 0;
> -#ifdef CONFIG_PM
> - =A0 =A0 retval =3D set_clock_run(pdev);
> -#endif

BTW, a comment from PNX folk (Vitaly/Kevin) would be appreciated. =A0= Why
does PNX enable the clock when going into suspend? =A0Should I assume that<= br> this should actually be disabling the clock?

As fa= r as I recall, at some point there was a function that was taking the secon= d boolean parameter (enable or disable the clock). So now it is, yes, not m= aking much sense.


Also, if Vitaly doesn't have anything to do with PNX4008 anymore, it would be a good idea to update the MAINTAINERS file.

I'd like to keep maintaining this platform, but = it's also up to NXP because I don't have the actual working hardwar= e now so there's not much I can do.

Vitaly
--0016e6d77eac72cecb04790de966-- --===============0751528294== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0751528294==--