From: Andi Shyti <andi.shyti@kernel.org>
To: adlavinitha reddy <adlavinitha.reddy@mediatek.com>
Cc: Qii Wang <qii.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [v1,PATCH 1/1] i2c: mediatek: add bus regulator control for power saving
Date: Wed, 15 Apr 2026 01:03:08 +0200 [thread overview]
Message-ID: <ad7FOoevcOm0AxP8@zenone.zhora.eu> (raw)
In-Reply-To: <20260318084621.4127757-2-adlavinitha.reddy@mediatek.com>
Hi Adlavinitha,
On Wed, Mar 18, 2026 at 04:46:16PM +0800, adlavinitha reddy wrote:
> Add conditional bus regulator enable/disable in mtk_i2c_transfer()
> to support I2C bus power gating for platforms that require it.
>
> This implementation:
> - Enables bus_regulator before clk_bulk_enable() if vbus-supply is defined
> - Disables bus_regulator after clk_bulk_disable()
> - Only activates when vbus-supply is provided in device tree
> - Has no impact on platforms without vbus-supply defined
>
> This approach provides power savinggs for platforms with an extra I2C bus
I changed /savinggs/savings/.
> regulator, while avoiding runtime PM complexity.
>
> TEST= Build and boot on MT8188
'"TEST=..." is a tag. There is no need to save characters in the
commit log. I changed it to "Tested on MT8188.".'
> Signed-off-by: adlavinitha reddy <adlavinitha.reddy@mediatek.com>
Please use capital letters for your name and for the committer's
name as well. I fixed it.
Now you have to explain me why you sent three times this same
patch.
Next time, please use the format '[PATCH v1 1/1]' instead of
'[v1,PATCH 1/1]'. Normally for the first version you can omit v1.
For single patches you don't need the 0/1 cover letter. Just send
as [PATCH].
Please read Documentation/SubmittingPatches.
For now I merged this patch in i2c/i2c-host-2.
Thanks,
Andi
next prev parent reply other threads:[~2026-04-14 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 8:46 [v1,PATCH 0/1] i2c: mediatek: add bus regulator control for power saving adlavinitha reddy
2026-03-18 8:46 ` [v1,PATCH 1/1] " adlavinitha reddy
2026-03-26 9:49 ` Chen-Yu Tsai
2026-04-14 23:03 ` Andi Shyti [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-18 8:42 [v1,PATCH 0/1] " adlavinitha reddy
2026-03-18 8:42 ` [v1,PATCH 1/1] " adlavinitha reddy
[not found] <20260318081126.4098146-1-adlavinitha.reddy@mediatek.com>
2026-03-18 8:11 ` adlavinitha reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad7FOoevcOm0AxP8@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=adlavinitha.reddy@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qii.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox