Linux I2C development
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: "Filippo Muscherà" <filippo.muschera@gmail.com>
Cc: jdelvare@suse.com, andriy.shevchenko@intel.com,
	 linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: amd8111: Switch to pcim_enable_device() and pcim_request_region()
Date: Wed, 15 Apr 2026 01:13:35 +0200	[thread overview]
Message-ID: <ad7JtwVqSMU0rPBT@zenone.zhora.eu> (raw)
In-Reply-To: <20260224102216.17606-1-filippo.muschera@gmail.com>

Hi Filippo,

On Tue, Feb 24, 2026 at 11:22:16AM +0100, Filippo Muscherà wrote:
> Following the conversion to managed devm_* APIs, update the driver to use
> the PCI-specific managed APIs.
> 
> Use pcim_enable_device() to properly enable the PCI device and
> pcim_request_region() to manage the I/O port region.
> 
> Switching to pcim_enable_device() also addresses the fact that
> pci_disable_device() was  missing in the driver lifecycle, as the
> managed API now automatically handles the disablement when the driver
> unbinds.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Filippo Muscherà <filippo.muschera@gmail.com>

Please, don't send a new patch as a in-reply-to to a different
patch. I personally don't like patches sent as reply to a
different thread, it makes my work as reviewer more difficult.

Said that, I would ask Jean to give an ack here.

Thanks,
Andi

      parent reply	other threads:[~2026-04-14 23:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 13:13 [PATCH 1/2] i2c: amd8111: Remove spaces in MODULE_* macros Filippo Muscherà
2026-02-02 13:13 ` [PATCH 2/2] i2c: amd8111: switch to devm_ functions Filippo Muscherà
2026-02-05 11:03   ` Andi Shyti
2026-02-05 12:57     ` Filippo Muscherà
2026-02-23 16:25   ` Andy Shevchenko
2026-02-24 10:22     ` [PATCH] i2c: amd8111: Switch to pcim_enable_device() and pcim_request_region() Filippo Muscherà
2026-02-24 10:38       ` Andy Shevchenko
2026-02-24 14:42         ` Filippo Muscherà
2026-04-14 23:13       ` Andi Shyti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad7JtwVqSMU0rPBT@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=filippo.muschera@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox