From: Bjorn Ardo <bjorn.ardo@axis.com>
To: Wolfram Sang <wsa@the-dreams.de>, Patrick Williams <patrick@stwcx.xyz>
Cc: "Björn Ardö" <bjornar@axis.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: slave-eeprom: initialize empty eeprom properly
Date: Tue, 21 Apr 2020 14:03:41 +0200 [thread overview]
Message-ID: <adb03545-88db-689c-dbf7-9f746236adb4@axis.com> (raw)
In-Reply-To: <20200420205325.GA1693@ninjato>
On 4/20/20 10:53 PM, Wolfram Sang wrote:
> On Mon, Apr 20, 2020 at 03:31:46PM -0500, Patrick Williams wrote:
>> On Mon, Apr 20, 2020 at 06:43:49PM +0200, Wolfram Sang wrote:
>>> On Wed, Oct 02, 2019 at 08:20:53AM +0200, Bjorn Ardo wrote:
>>>> Hi,
>>>>
>>>>
>>>> I sent in another patch earlier that added support for specifying a file in
>>>> devicetree to initilize the eeprom from, corresponding to the case of
>>>> pre-flashed eeprom. Maybe these two patches should be merged so this
>>>> initialization is only done if no file is specified?
>>> Yes, I agree.
>>>
>> It looks like Bjorn's referenced patches are still unmerged also?
> Yes, it might be easiest if he merges your patch (with attribution) into
> the else branch of his fw-load patch.
>
OK, so to summarize, I should update my patch to use
device_property_read_string() instead and also init the memory to 0XFF
if no file is present. And change name of the function to
i2c_slave_init_eeprom_data.
I will look into that and let you know once I'm done.
/BA
next prev parent reply other threads:[~2020-04-21 12:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 16:40 [PATCH 1/2] i2c: slave-eeprom: initialize empty eeprom properly Patrick Williams
2019-10-01 16:40 ` [PATCH 2/2] i2c: slave-eeprom: support additional models Patrick Williams
2020-04-20 16:46 ` Wolfram Sang
2020-04-20 20:23 ` Patrick Williams
2019-10-02 6:20 ` [PATCH 1/2] i2c: slave-eeprom: initialize empty eeprom properly Bjorn Ardo
2020-04-20 16:43 ` Wolfram Sang
2020-04-20 20:24 ` Patrick Williams
2020-04-20 20:31 ` Patrick Williams
2020-04-20 20:53 ` Wolfram Sang
2020-04-21 12:03 ` Bjorn Ardo [this message]
2020-04-21 12:16 ` Wolfram Sang
2020-04-22 9:30 ` Bjorn Ardo
2020-04-22 9:36 ` Wolfram Sang
2020-04-24 9:06 ` Bjorn Ardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adb03545-88db-689c-dbf7-9f746236adb4@axis.com \
--to=bjorn.ardo@axis.com \
--cc=bjornar@axis.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).