public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: "V, Narasimhan" <Narasimhan.V@amd.com>,
	Borislav Petkov <bp@alien8.de>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>
Subject: Re: i2c-designware: NULL ptr at RIP: 0010:regmap_read+0x12/0x70
Date: Thu, 4 Jan 2024 15:40:44 +0200	[thread overview]
Message-ID: <adf6c24a-d94b-40e5-b645-0c6b23b2d513@linux.intel.com> (raw)
In-Reply-To: <DM4PR12MB5086DE2882C7C5044697B1C38967A@DM4PR12MB5086.namprd12.prod.outlook.com>

On 1/4/24 08:35, V, Narasimhan wrote:
>> [    6.245173] i2c_designware AMDI0010:00: Unknown Synopsys component type: 0xffffffff
> 
> This made me scratching my head since driver probing will fail in this
> case with -ENODEV and I could not trigger runtime PM activity in such
> case but perhaps this is timing specific which happens to happen in your
> case.
> 
> Out of curiosity do you see this same "i2c_designware AMDI0010:00:
> Unknown Synopsys component type: 0xffffffff" error on Vanilla or is it
> also regression in linux-next?
> 
> This does not happen on Vanilla, only on linux-next.
> 
This is even more strange. Controller is in reset but I'm blind to see 
from Andy's patches why. Do you have change to test at these commits?

bd466a892612 ("i2c: designware: Fix PM calls order in dw_i2c_plat_probe()")
c012fde343d2 ("i2c: designware: Fix reset call order in dw_i2c_plat_probe()"

and maybe the last one
4bff054b64e1 ("i2c: designware: Fix spelling and other issues in the 
comments")

I'm trying to narrow does the regression come from first two patches and 
if not, then test the last one.

Andy is out of office and if we can narrow the regression to first two 
patches we perhaps can revert just them and otherwise need to drop the 
whole set.

  parent reply	other threads:[~2024-01-04 13:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-29 12:08 i2c-designware: NULL ptr at RIP: 0010:regmap_read+0x12/0x70 Borislav Petkov
2024-01-02 13:42 ` Jarkko Nikula
     [not found]   ` <DM4PR12MB508654DF49FE079D6C283D658961A@DM4PR12MB5086.namprd12.prod.outlook.com>
2024-01-03 15:25     ` Jarkko Nikula
     [not found]       ` <DM4PR12MB5086DE2882C7C5044697B1C38967A@DM4PR12MB5086.namprd12.prod.outlook.com>
2024-01-04 13:40         ` Jarkko Nikula [this message]
2024-01-06 16:06           ` Andy Shevchenko
     [not found]           ` <DM4PR12MB508652E9A422CF639C2FEEC0896A2@DM4PR12MB5086.namprd12.prod.outlook.com>
2024-01-09 10:11             ` Jarkko Nikula
2024-01-10 22:56               ` Kim Phillips
2024-01-11 13:01                 ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adf6c24a-d94b-40e5-b645-0c6b23b2d513@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Narasimhan.V@amd.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox