Re: [PATCH v3 4/5] arm64: dts: qcom: sdm670: add camcc

[Konrad Dybcio <konradybcio@kernel.org>]

On 20.08.2024 11:23 AM, Vladimir Zapolskiy wrote:
> On 8/20/24 01:10, Richard Acayan wrote:
>> The camera clock controller on SDM670 controls the clocks that drive the
>> camera subsystem. The clocks are the same as on SDM845. Add the camera
>> clock controller for SDM670.
>>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm670.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
>> index 187c6698835d..ba93cef33dbb 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
>> @@ -1400,6 +1400,16 @@ spmi_bus: spmi@c440000 {
>>               #interrupt-cells = <4>;
>>           };
>>   +        camcc: clock-controller@ad00000 {
>> +            compatible = "qcom,sdm845-camcc";
> 
> Here it's wrong, and the compatible property value shall contain
> "qcom,sdm670-camcc", probably it could contain both values though.
> 
> It may require to add a new compatible to dt documentation and,
> if needed, to the corresponding clock driver.

+1, even if the blocks are physically the same, please add a SoC-specific
compatible (with a fallback to 845 if that's the case) just in case there
are some implementation problems only concerning this instance

Konrad