From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] i2c: change return type to bool for i2c_check_functionality
Date: Mon, 4 May 2026 11:15:19 +0200 [thread overview]
Message-ID: <afhjp_ib0padlv5z@ninjato> (raw)
In-Reply-To: <20260421161607.61314-3-thorsten.blum@linux.dev>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On Tue, Apr 21, 2026 at 06:16:09PM +0200, Thorsten Blum wrote:
> i2c_check_functionality() returns a bool - change the return type from
> int to bool and update the comment accordingly.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Basically OK but you need to fix the in-tree user first using the 'int'
behaviour [1]. I'd think you can send it with this patch as one series
and have it go in via the I2C tree, but Lee has to agree then.
[1] $ git grep 'i2c_check_functionality.*='
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-05-04 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 16:16 [PATCH RESEND] i2c: change return type to bool for i2c_check_functionality Thorsten Blum
2026-04-22 12:29 ` Mukesh Savaliya
2026-05-04 9:15 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afhjp_ib0padlv5z@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox