From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "William A. Kennington III" <william@wkennington.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] i2c: designware: Improve device disable handling
Date: Tue, 5 May 2026 10:35:53 +0300 [thread overview]
Message-ID: <afmd2ax-GmcKsSQ5@ashevche-desk.local> (raw)
In-Reply-To: <20260504-dw-i2c-v3-0-57e56135d602@wkennington.com>
On Mon, May 04, 2026 at 08:15:01PM +0000, William A. Kennington III wrote:
> When the I2C master attempts a new transaction while the slave
> controller is shutting down or restarting, it can lead to bus lockups
> and system bootloops if the hardware enters an inconsistent state.
>
> This patch series addresses this by ensuring that the internal state
> machines are properly cleared when disabling the controller if slave
> activity is detected.
>
> Additionally, it adds a shutdown hook that gracefully sets the slave
> disable bit before disabling the controller. This guarantees that any
> incoming requests from the master are immediately NACKed during
> shutdown, preventing the bus from hanging.
In general series looks good, just some style issues, see individual replies.
If you address them as suggested, I will give my tag against v4.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-05 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 20:15 [PATCH v3 0/4] i2c: designware: Improve device disable handling William A. Kennington III
2026-05-04 20:15 ` [PATCH v3 1/4] i2c: designware: Introduce shutdown exported function William A. Kennington III
2026-05-05 7:29 ` Andy Shevchenko
2026-05-04 20:15 ` [PATCH v3 2/4] i2c: designware: Convert PCI driver to use shutdown hook William A. Kennington III
2026-05-05 7:31 ` Andy Shevchenko
2026-05-04 20:15 ` [PATCH v3 3/4] i2c: designware: Convert platform " William A. Kennington III
2026-05-05 7:31 ` Andy Shevchenko
2026-05-04 20:15 ` [PATCH v3 4/4] i2c: designware: Handle active slave cleanly William A. Kennington III
2026-05-05 7:34 ` Andy Shevchenko
2026-05-05 7:35 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afmd2ax-GmcKsSQ5@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=william@wkennington.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox