From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hardik Prakash <hardikprakash.official@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org,
linus.walleij@linaro.org, wsa@kernel.org
Subject: Re: [PATCH v2 0/2] Fix WACF2200 touchscreen on Lenovo Yoga 7 14AGP11
Date: Wed, 13 May 2026 20:03:54 +0300 [thread overview]
Message-ID: <agSu-jGOuhMscg9A@ashevche-desk.local> (raw)
In-Reply-To: <20260513061338.9348-1-hardikprakash.official@gmail.com>
On Wed, May 13, 2026 at 11:43:36AM +0530, Hardik Prakash wrote:
> The Wacom WACF2200 touchscreen on the Lenovo Yoga 7 14AGP11 (83TD) is
> completely non-functional on Linux. The I2C bus (AMDI0010:02) fails with
> repeated lost arbitration errors at boot before any driver can probe the
> device. The touchscreen works correctly in UEFI and Windows.
>
> Investigation using ACPI _CRS decode and Windows/Linux GPIO register
> comparison identified two bugs:
>
> 1. GPIO 157 (WACF2200 GpioInt per ACPI _CRS) has INTERRUPT_ENABLE and
> INTERRUPT_MASK cleared by amd_gpio_irq_init() and never restored,
> preventing the device from signalling the driver. Windows keeps both
> bits set after initialisation.
>
> 2. i2c_designware probes AMDI0010:02 before pinctrl-amd's probe
> completes. A DMI-matched deferral is added to correctly enforce
> ordering using device_is_bound() under device_lock().
>
> Patch 1 adds a DMI quirk in pinctrl-amd to restore GPIO 157 interrupt
> bits after amd_gpio_irq_init().
>
> Patch 2 adds a probe deferral in i2c-designware-platdrv that correctly
> waits for pinctrl-amd to fully complete before AMDI0010:02 is probed,
> using acpi_dev_get_first_match_dev() and acpi_get_first_physical_node()
> for robust device lookup.
>
> Both patches tested on Lenovo Yoga 7 14AGP11 (83TD), Fedora 44, kernel
> 7.1.0-rc2+. Touch and stylus fully functional across 4 stable reboots.
The Subject in the patches misses versioning, use
git format-patch -v<N> --cover-letter ...
where <N> is the version, to get proper format in the Subject.
Also link to the bugzilla makes sense as BugLink tag in the patch(es):
BugLink: $URL
Or simple Link.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-13 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 6:13 [PATCH v2 0/2] Fix WACF2200 touchscreen on Lenovo Yoga 7 14AGP11 Hardik Prakash
2026-05-13 6:13 ` [PATCH 1/2] pinctrl-amd: enable IRQ for " Hardik Prakash
2026-05-13 7:36 ` Linus Walleij
2026-05-13 17:23 ` Mario Limonciello
[not found] ` <CANTFpSUr7KWMA5D7wh48f5-Ty9hDo7U7Ydsob32YZuZ83dRiiw@mail.gmail.com>
2026-05-14 5:12 ` Hardik Prakash
2026-05-13 6:13 ` [PATCH 2/2] i2c: designware: fix probe ordering for AMD GPIO " Hardik Prakash
2026-05-13 17:12 ` Andy Shevchenko
2026-05-13 17:28 ` Mario Limonciello
[not found] ` <CANTFpSU=94RuX1uFf4UitRyzLPvu=cTF_S5khjjJNQUU1T_PtA@mail.gmail.com>
2026-05-14 5:14 ` Hardik Prakash
2026-05-14 5:43 ` Hardik Prakash
2026-05-13 17:03 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agSu-jGOuhMscg9A@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=hardikprakash.official@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox