From: Wolfram Sang <wsa@sang-engineering.com>
To: Claudiu Beznea <claudiu.beznea@kernel.org>
Cc: chris.brandt@renesas.com, andi.shyti@kernel.org,
claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] i2c: riic: Abort the transfer on completion timeout
Date: Thu, 28 May 2026 23:52:08 +0200 [thread overview]
Message-ID: <ahi5CC7t_Im4pWfT@shikoro> (raw)
In-Reply-To: <88d1db83-1127-462f-9b1a-7c18a7087960@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
> I haven't managed to reproduce it on i2c. I reproduced a similar behavior
> while working on renesas-i3c driver and decided to implement this on this
> i2c driver as well.
I think the issue is real, but I am not convinced the solution is
complete without a verified testcase.
Maybe it is not too hard to test: you could hack the timeout to be lower
and then write a block of data to an EEPROM. Its erase cycle can trigger
the timeout then...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-05-28 21:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 13:12 [PATCH 0/4] i2c: riic: Fixes and cleanups Claudiu Beznea
2026-05-20 13:12 ` [PATCH 1/4] i2c: riic: Abort the transfer on completion timeout Claudiu Beznea
2026-05-28 13:57 ` Wolfram Sang
2026-05-28 16:57 ` Claudiu Beznea
2026-05-28 21:52 ` Wolfram Sang [this message]
2026-05-20 13:12 ` [PATCH 2/4] i2c: riic: Use the "dev_name:irq_name" format for the interrupt name Claudiu Beznea
2026-05-28 14:03 ` Wolfram Sang
2026-05-20 13:12 ` [PATCH 3/4] i2c: riic: Drop the space in front of the "out" goto label Claudiu Beznea
2026-05-28 14:08 ` Wolfram Sang
2026-05-28 17:00 ` Claudiu Beznea
2026-05-28 21:52 ` Wolfram Sang
2026-05-20 13:12 ` [PATCH 4/4] i2c: riic: Drop empty line Claudiu Beznea
2026-05-28 14:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahi5CC7t_Im4pWfT@shikoro \
--to=wsa@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=chris.brandt@renesas.com \
--cc=claudiu.beznea@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox