Re: [PATCH v2] i2c-tools: Allow passing device file paths

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

Hi Brigham, Gero,

> I had worried that doing the device path lookup and opening in one go
> would be overly invasive. Of course, if I can make that work, then it
> would address the concerns that I brought up in my previous email. It
> may be worth the extra effort to avoid the ugly variant struct I
> introduced in this v2.
> 
> I'll take a look at libgpio. Thanks.

I think I agree with Gero here and that it is worth getting rid of the
variant struct.

> This makes sense. In the strange (but totally plausible) case of
> conflicts between bus number, bus name, and bus file/symlink path, the
> order of precedence should be as follows to maintain backwards
> compatibility:
> 
> bus number -> bus name -> bus device path
> 
> I'll fix this in the next revision.

Sounds good!

Looking forward to v3, happy hacking!

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]