From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E8F8480DD3 for ; Wed, 3 Jun 2026 13:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780492499; cv=none; b=DHPVfSpAzj1dxeOpqn15tIL0rXfqpEQXwbYwJXK5ytib8zrLNdmwcTkAZnudOG3KmHB7qskigb7cE5Oe3agFeby6G/fJWt6DykQWJoHdjjbcc8iQrndFoprmr/Ga0pl2rBeDQkoF8sw2+2qBRjc9zGJSO0z9OiD6H4wtIWWC+Gg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780492499; c=relaxed/simple; bh=mMYK5Q2ek6ZmeO361IA+ZAcaRRX6L05wod0xSsYtO4Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qddvfKwQ52pX8DrJmqOQtSek2NOjO9YE0j/ZaXT7gAyJzMuUiffxiNMRg0fhiEEuWCVr6tDUTbV4m0rQvPm9uJdoQlPaZJ3YW7d9wi9chaxLRUqEASJgdgg2N97o8YjAqhW0pvmSD+5I+3zzBP2t0305bV6g1LqxMZP8DgpXFiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=NSyhkXk/; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="NSyhkXk/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=Ouf7 mBHEDsmccuHvUASszmfTiWBF750HqGo9Wt8MppI=; b=NSyhkXk/ty44OWCj2rVV 3Bfrfw9pf9RN1wsp13bQO6Tb30JUW3a4ghLx7jmedLofQ/szChLp1+zYSWqrQBJl TaAk4m7qj71W6sF40luS3rpBxzaM+61MTVgGLRHQxSks+NUaLjQd1VLZsENadiqH 9xcVieJs5eQY/swKEzfe0+aCSvzb063HJN3wJS0PsSb+qB5w7pAWrS6qhIxDaNXm Oqw6JRyj9eaib6iC9bwB7UrYODI4R0LDRIn5TGdAxlsn2XFJcDOUsMEIah4gDe0K 89zBy/iIYUZfpLVpDbBckax69C0er9eU+LEcwYWZW7IYf5kjBDaCIFyflIDRgFm/ Lg== Received: (qmail 3289264 invoked from network); 3 Jun 2026 15:14:55 +0200 Received: by mail.zeus03.de with UTF8SMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 3 Jun 2026 15:14:55 +0200 X-UD-Smtp-Session: l3s3148p1@0US3NllToJ8ujnsK Date: Wed, 3 Jun 2026 15:14:54 +0200 From: Wolfram Sang To: Johan Hovold Cc: Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 05/10] i2c: core: fix adapter debugfs creation Message-ID: References: <20260511143715.729714-1-johan@kernel.org> <20260511143715.729714-6-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260511143715.729714-6-johan@kernel.org> On Mon, May 11, 2026 at 04:37:10PM +0200, Johan Hovold wrote: > Clients can be registered from bus notifier callbacks so the debugfs > directory needs to be created before registering the adapter as clients > use that directory as their debugfs parent. > > Move debugfs creation before adapter registration to avoid having > clients create their debugfs directories in the debugfs root (which is > also more likely to fail due to name collisions). > > Note that failure to allocate the adapter name must now be handled > explicitly as debugfs_create_dir() cannot handle a NULL name (unlike > device_add() which returns an error). > > Fixes: 73febd775bdb ("i2c: create debugfs entry per adapter") > Cc: stable@vger.kernel.org # 6.8 > Cc: Wolfram Sang > Signed-off-by: Johan Hovold Reviewed-by: Wolfram Sang