Linux I2C development
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: algo: bit: use str_plural helper in bit_xfer
Date: Sat, 6 Jun 2026 23:20:57 +0200	[thread overview]
Message-ID: <aiSPOfKPkrqcYa8b@linux.dev> (raw)
In-Reply-To: <20260511104911.183606-3-thorsten.blum@linux.dev>

Gentle ping?

On Mon, May 11, 2026 at 12:49:13PM +0200, Thorsten Blum wrote:
> Replace the manual ternary "s" pluralizations with str_plural() to
> simplify the code.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  drivers/i2c/algos/i2c-algo-bit.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
> index 6544d27e4419..d1d9a6c1a1e2 100644
> --- a/drivers/i2c/algos/i2c-algo-bit.c
> +++ b/drivers/i2c/algos/i2c-algo-bit.c
> @@ -13,6 +13,7 @@
>  #include <linux/delay.h>
>  #include <linux/errno.h>
>  #include <linux/sched.h>
> +#include <linux/string_choices.h>
>  #include <linux/i2c.h>
>  #include <linux/i2c-algo-bit.h>
>  
> @@ -562,7 +563,7 @@ static int bit_xfer(struct i2c_adapter *i2c_adap,
>  			ret = readbytes(i2c_adap, pmsg);
>  			if (ret >= 1)
>  				bit_dbg(2, &i2c_adap->dev, "read %d byte%s\n",
> -					ret, ret == 1 ? "" : "s");
> +					ret, str_plural(ret));
>  			if (ret < pmsg->len) {
>  				if (ret >= 0)
>  					ret = -EIO;
> @@ -573,7 +574,7 @@ static int bit_xfer(struct i2c_adapter *i2c_adap,
>  			ret = sendbytes(i2c_adap, pmsg);
>  			if (ret >= 1)
>  				bit_dbg(2, &i2c_adap->dev, "wrote %d byte%s\n",
> -					ret, ret == 1 ? "" : "s");
> +					ret, str_plural(ret));
>  			if (ret < pmsg->len) {
>  				if (ret >= 0)
>  					ret = -EIO;

      reply	other threads:[~2026-06-06 21:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 10:49 [PATCH] i2c: algo: bit: use str_plural helper in bit_xfer Thorsten Blum
2026-06-06 21:20 ` Thorsten Blum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiSPOfKPkrqcYa8b@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=andi.shyti@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox