From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] i2c: pxa: Use named initializers for the platform_device_id array
Date: Thu, 18 Jun 2026 14:24:25 +0200 [thread overview]
Message-ID: <ajPjJbYrtZJ09rDW@monoceros> (raw)
In-Reply-To: <ajPSo2zjDvq7CflO@zenone.zhora.eu>
[-- Attachment #1: Type: text/plain, Size: 960 bytes --]
On Thu, Jun 18, 2026 at 01:14:04PM +0200, Andi Shyti wrote:
> Hi Uwe,
>
> On Wed, Jun 17, 2026 at 11:37:36AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > Named initializers are better readable and more robust to changes of the
> > struct definition. This robustness is relevant for a planned change to
> > struct platform_device_id replacing .driver_data by an anonymous union.
> >
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
>
> I had decided not to take any patch anymore for this cycle, but
> because this is part of a bigger work you've done, I will squeeze
> it in.
>
> Merged to i2c/i2c-host.
Thanks. If you want to rethink that's fine. There are still so many
patches pending (to be applied and to be sent) that there is little
sense in rushing in that one. I'm happy if you take it now, but if you
reschedule it to the next merge window, that's fine for me, too.
Thanks
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-06-18 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 9:37 [PATCH v1] i2c: pxa: Use named initializers for the platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-06-18 11:14 ` Andi Shyti
2026-06-18 12:24 ` Uwe Kleine-König (The Capable Hub) [this message]
2026-06-18 14:18 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajPjJbYrtZJ09rDW@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox