Re: [PATCH v3 08/16] i2c: Let i2c-core.h include <linux/i2c.h>

["Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

Hallo Wolfram,

On Mon, Jun 29, 2026 at 08:31:50AM +0200, Wolfram Sang wrote:
> On Sun, Jun 28, 2026 at 11:58:43PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > The subsystem private header i2c-core.h uses several symbols defined in
> > <linux/i2c.h>, e.g. struct i2c_board_info and i2c_lock_bus()). This
> > doesn't pose a problem in practise because all files including
> > "i2c-core.h" also include <linux/i2c.h>.
> > 
> > To make this more robust add an include statement for <linux/i2c.h>
> > making the header self-contained.
> > 
> > Acked-by: Danilo Krummrich <dakr@kernel.org>
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> This shall go upstream with the rest of the series, right?

Yes, that's the plan. Linus didn't explicitly say he's happy with
merging this for -rc2, but he also didn't contradict, so I assume that
is what will happen.

For bisectability it isn't needed to let these go all together, but
given that the first patch touches <linux/mod_devicetable.h> which is an
intrusive change resulting in the need to rebuild nearly the complete
tree when pulled in, do the intrusive follow up changes in the same go
to only trigger the needed rebuild once.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]