From: Andi Shyti <andi.shyti@kernel.org>
To: Pei Xiao <xiaopei01@kylinos.cn>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
troy.mitchell@linux.spacemit.com
Subject: Re: [PATCH v2] i2c: spacemit: fix spurious IRQ handling returning IRQ_HANDLED
Date: Tue, 14 Jul 2026 19:19:44 +0200 [thread overview]
Message-ID: <alZvn3D1JXiAz_IK@zenone.zhora.eu> (raw)
In-Reply-To: <ef8b623f45d4e430721e46572c2598d882044aed.1783667875.git.xiaopei01@kylinos.cn>
Hi Pei,
On Fri, Jul 10, 2026 at 03:21:13PM +0800, Pei Xiao wrote:
> When the interrupt status register reads zero, the handler should
> return IRQ_NONE instead of IRQ_HANDLED. What the return value
> actually feeds into is the spurious interrupt accounting in
> note_interrupt(): falsely claiming IRQ_HANDLED defeats the "irq XX:
> nobody cared" detection, so a stuck interrupt source would never be
> caught.
>
> Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
merged to i2c/i2c-fixes.
Thanks,
Andi
prev parent reply other threads:[~2026-07-14 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 7:14 [PATCH] i2c: spacemit: fix spurious IRQ handling returning IRQ_HANDLED Pei Xiao
2026-07-10 7:21 ` [PATCH v2] " Pei Xiao
2026-07-10 7:46 ` Troy Mitchell
2026-07-10 9:18 ` Pei Xiao
2026-07-13 9:01 ` Troy Mitchell
2026-07-14 15:37 ` Andi Shyti
2026-07-10 8:50 ` Mukesh Savaliya
2026-07-10 9:28 ` Pei Xiao
2026-07-13 5:15 ` Mukesh Savaliya
2026-07-14 17:19 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alZvn3D1JXiAz_IK@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox