From: Julia Lawall <julia.lawall@lip6.fr>
To: Joel Stanley <joel@jms.id.au>
Cc: kbuild-all@01.org, Jeremy Kerr <jk@ozlabs.org>,
Milton Miller <miltonm@us.ibm.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] i2c: fix device_node_continue.cocci warnings
Date: Mon, 19 Sep 2016 11:47:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1609191146130.3203@hadrien> (raw)
Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.
Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
Please take the patch only if it's a positive warning. Thanks!
I haven't checked anything more that what is shown in the patch.
julia
i2c-aspeed.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -862,7 +862,6 @@ static int ast_i2c_probe_controller(stru
continue;
of_platform_device_create(np, bus_id, &pdev->dev);
- of_node_put(np);
}
return 0;
reply other threads:[~2016-09-19 9:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1609191146130.3203@hadrien \
--to=julia.lawall@lip6.fr \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=kbuild-all@01.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@us.ibm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox