public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: Gregory Bean <gbean-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver.
Date: Tue, 20 Jul 2010 10:21:35 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1007201019300.8107@localhost.localdomain> (raw)
In-Reply-To: <20100719163142.16cab271.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>


On Mon, 19 Jul 2010, Andrew Morton wrote:

> On Thu,  8 Jul 2010 12:37:14 -0700
> Gregory Bean <gbean-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
> 
> > Add support for Semtech SX150-series I2C GPIO expanders.
> 
> It doesn't work when compiled as a module:
> 
> ERROR: "irq_to_desc" [drivers/gpio/sx150x.ko] undefined!
> ERROR: "handle_edge_irq" [drivers/gpio/sx150x.ko] undefined!
> ERROR: "set_irq_chip_and_handler" [drivers/gpio/sx150x.ko] undefined!
> ERROR: "set_irq_noprobe" [drivers/gpio/sx150x.ko] undefined!
> 
> I think there's a reason why some of those things aren't exported to
> modules.  Perhaps Thomas can remind us?

There was no requirement to do so, it came up with those I2C irq
controllers lately. I don't have a strong feeling, but if we can avoid
the export I'd feel more comfortable.

Thanks,

	tglx

      parent reply	other threads:[~2010-07-20  8:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08 19:37 [PATCH v2] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver Gregory Bean
     [not found] ` <1278617834-14970-1-git-send-email-gbean-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2010-07-09 11:57   ` Trilok Soni
     [not found]     ` <4C370EB4.4040906-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2010-07-12  8:55       ` Trilok Soni
     [not found]         ` <4C3AD87C.1010407-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2010-07-12 23:46           ` Andrew Morton
2010-07-19 23:31   ` Andrew Morton
     [not found]     ` <20100719163142.16cab271.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-07-19 23:50       ` Andrew Morton
     [not found]         ` <20100719165038.a308b019.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-07-20  9:25           ` Mark Brown
2010-07-20  8:21       ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1007201019300.8107@localhost.localdomain \
    --to=tglx-hfztesqfncyowbw4kg4ksq@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=gbean-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox