From: Andi Shyti <andi.shyti@kernel.org>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Robert Foss <rfoss@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Luca Weiss <luca@lucaweiss.eu>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, vladimir.zapolskiy@linaro.org,
konradybcio@kernel.org, stephan.gerhold@linaro.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Subject: Re: [PATCH v3 5/5] i2c: qcom-cci: Enforce the required CCI clock rate
Date: Fri, 31 Jul 2026 22:55:46 +0200 [thread overview]
Message-ID: <am0Li7jT2BQAI54k@zenone.zhora.eu> (raw)
In-Reply-To: <20260729-cci-clk-fix-v3-5-f3c731d1596e@oss.qualcomm.com>
Hi Loic,
...
> @@ -588,6 +646,10 @@ static int __maybe_unused cci_resume_runtime(struct device *dev)
> struct cci *cci = dev_get_drvdata(dev);
> int ret;
>
> + ret = cci_set_core_rate(cci, cci_get_required_rate(cci));
> + if (ret)
> + return ret;
> +
> ret = cci_enable_clocks(cci);
> if (ret)
> return ret;
> @@ -694,6 +756,19 @@ static int cci_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(cci->cci_clk),
> "failed to get CCI clock\n");
>
> + ret = devm_pm_opp_set_clkname(dev, "cci");
> + if (ret)
> + return dev_err_probe(dev, ret, "failed to set CCI OPP clk\n");
what if CONFIG_PM_OPP is not configured in?
Thanks,
Andi
> +
> + /* OPP table is optional */
> + ret = devm_pm_opp_of_add_table(dev);
> + if (ret && ret != -ENODEV)
> + return dev_err_probe(dev, ret, "failed to add OPP table\n");
next prev parent reply other threads:[~2026-07-31 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 12:25 [PATCH v3 0/5] i2c: qcom-cci: Enforce the required CCI clock rate Loic Poulain
2026-07-29 12:25 ` [PATCH v3 1/5] i2c: qcom-cci: Switch msm8953 to the CCI v2 timing/rate config Loic Poulain
2026-07-31 14:06 ` Konrad Dybcio
2026-07-31 14:25 ` Loic Poulain
2026-08-03 2:28 ` Wenmeng Liu
2026-07-29 12:25 ` [PATCH v3 2/5] i2c: qcom-cci: Support per-mode CCI clock rates Loic Poulain
2026-07-29 12:25 ` [PATCH v3 3/5] i2c: qcom-cci: Add 19.2 MHz timings for the v2 CCI Loic Poulain
2026-07-29 12:25 ` [PATCH v3 4/5] i2c: qcom-cci: Share the timing table across CCI revisions Loic Poulain
2026-07-29 12:25 ` [PATCH v3 5/5] i2c: qcom-cci: Enforce the required CCI clock rate Loic Poulain
2026-07-31 20:55 ` Andi Shyti [this message]
2026-08-01 7:14 ` Loic Poulain
2026-07-31 20:54 ` [PATCH v3 0/5] " Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am0Li7jT2BQAI54k@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=luca@lucaweiss.eu \
--cc=rfoss@kernel.org \
--cc=stephan.gerhold@linaro.org \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wenmeng.liu@oss.qualcomm.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox