From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "clarke.li" <clarke.li@hj-micro.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
andy.xu@hj-micro.com, peter.du@hj-micro.com
Subject: Re: [PATCH v4 1/2] ACPI: APD: Convert fixed clock rates to use HZ_PER_MHZ
Date: Thu, 13 Aug 2026 10:35:41 +0300 [thread overview]
Message-ID: <an1zzWb0mpm1huz_@ashevche-desk.local> (raw)
In-Reply-To: <20260813063005.42925-1-clarke.li@hj-micro.com>
On Thu, Aug 13, 2026 at 02:30:04PM +0800, clarke.li wrote:
> Use HZ_PER_MHZ multiplier for fixed_clk_rate values to
> improve readability.
And actually increases robustness of the code as there is less chances
to miss a 0 or have an extra one.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-13 7:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 2:40 [PATCH v2 0/2] i2c: Add ACPI support for HJMC01 hunter.yu
2024-09-26 2:40 ` [PATCH v2 1/2] ACPI: APD: Add clock frequency for HJMC01 I2C controller hunter.yu
2024-10-02 22:13 ` Andi Shyti
2024-10-16 20:45 ` Rafael J. Wysocki
2024-10-17 9:26 ` Andy Shevchenko
2024-10-17 9:28 ` Andy Shevchenko
2024-10-17 10:46 ` Rafael J. Wysocki
2024-10-18 2:02 ` Hunter Yu
2024-09-26 2:40 ` [PATCH v2 2/2] i2c: designware: Add a new ACPI HID " hunter.yu
2024-09-26 8:44 ` Jarkko Nikula
2024-09-26 12:15 ` [PATCH v2 0/2] i2c: Add ACPI support for HJMC01 Andy Shevchenko
2024-10-03 12:56 ` Andi Shyti
2024-11-18 15:54 ` Andi Shyti
2026-07-22 7:30 ` [PATCH v3] ACPI: APD: Add clock frequency for HJMC01 I2C controller clarke.li
2026-08-06 20:31 ` Andy Shevchenko
2026-08-11 6:22 ` clarke.li
2026-08-11 6:54 ` Andy Shevchenko
2026-08-11 9:07 ` clarke.li
2026-08-13 6:30 ` [PATCH v4 1/2] ACPI: APD: Convert fixed clock rates to use HZ_PER_MHZ clarke.li
2026-08-13 6:40 ` [PATCH v4 2/2] ACPI: APD: Add clock frequency for HJMC01 I2C controller clarke.li
2026-08-13 7:46 ` Andy Shevchenko
2026-08-13 7:35 ` Andy Shevchenko [this message]
2026-08-14 20:11 ` [PATCH v4 1/2] ACPI: APD: Convert fixed clock rates to use HZ_PER_MHZ Rafael J. Wysocki (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an1zzWb0mpm1huz_@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andy.xu@hj-micro.com \
--cc=clarke.li@hj-micro.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.du@hj-micro.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox