From: Peter Rosin <peda@lysator.liu.se>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Farhad Alemi <farhad.alemi@berkeley.edu>,
falemi@asu.edu, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: mux: avoid WARN on benign symlink creation failures
Date: Sun, 30 Aug 2026 23:14:47 +0200 [thread overview]
Message-ID: <apSdR2m-uibYHxVI@gryt> (raw)
In-Reply-To: <apSAfJARPgsbSDYb@zenone.zhora.eu>
Den Sun, Aug 30, 2026 at 09:13:24PM +0200, skrev Andi Shyti:
> Hi Peter,
>
> On Sun, Aug 30, 2026 at 06:13:03AM +0200, Peter Rosin wrote:
> > WARN() is a bit harsh and causes a crash for panic-on-warn users. Degrade
> > the error reporting to ordinary dev_err() calls.
> >
> > Reported-by: Farhad Alemi <farhad.alemi@berkeley.edu>
> > Link: https://lore.kernel.org/all/CA+0ovCij3QDLRzt8CwpjBy-BbJ5Zf5SV9w9QZXz8uD3Agws31g@mail.gmail.com/
> > Signed-off-by: Peter Rosin <peda@lysator.liu.se>
> > ---
> >
> > Hi Farhad,
> >
> > I assume this patch helps?
>
> I sent this patch for a quick test:
>
> https://lore.kernel.org/all/20260828135950.454799-1-andi.shyti@kernel.org/
>
> Maybe they can be taken together, as I agree not to fire a WARN()
> there.
Hi Andi,
[sorry for droping you from cc, that was unintentional]
Yes, sure! And fixing the root cause is of course always nice, good one!
Cheers,
Peter
prev parent reply other threads:[~2026-08-30 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 5:49 [BUG] WARNING in i2c_mux_add_adapter Farhad Alemi
2026-08-30 4:13 ` [PATCH] i2c: mux: avoid WARN on benign symlink creation failures Peter Rosin
2026-08-30 19:13 ` Andi Shyti
2026-08-30 21:14 ` Peter Rosin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apSdR2m-uibYHxVI@gryt \
--to=peda@lysator.liu.se \
--cc=andi.shyti@kernel.org \
--cc=falemi@asu.edu \
--cc=farhad.alemi@berkeley.edu \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox